-
Notifications
You must be signed in to change notification settings - Fork 128
Comments
Fix async_alert to respect allow_style setting for 3.x branch#1582
Fix async_alert to respect allow_style setting for 3.x branch #1582tleonhardt merged 2 commits into3.x from
Conversation
🤖 Hi @tleonhardt, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## 3.x #1582 +/- ## ====================================== Coverage ? 99.23% ====================================== Files ? 21 Lines ? 4844 Branches ? 0 ====================================== Hits ? 4807 Misses ? 37 Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
🤖 I'm sorry @tleonhardt, but I was unable to process your request. Please see the logs for more details.
@kmvanbrunt
kmvanbrunt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but don't cherry pick this into main since I'm rewriting the async_alert code for 4.x.
tleonhardt
commented
Feb 21, 2026
@kmvanbrunt I'll merge this into the 3.x branch and won't cherry-pick it to main since you are in the middle of re-writing the async_alert code for 4.x. Please make sure the new code respects that allow_style setting.
Uh oh!
There was an error while loading. Please reload this page.
This PR fixes the
async_alertmethod and other methods which use it such asasync_update_promptso that it respects theallow_stylesettable and strips out ANSI escape codes whenallow_styleisNEVER.This closes #1581
We will need to make equivalent changes on the
mainbranch after this merges to the3.xbranch but it won't be from a simple cherry-pick.