-
Notifications
You must be signed in to change notification settings - Fork 128
Comments
Remove dependency on Python's built-in cmd module#1539
Merged
tleonhardt merged 6 commits intomain from Dec 11, 2025
Merged
Conversation
The cmd2.Cmd class no longer inhertis from cmd.Cmd
Contributor
🤖 Hi @tleonhardt, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #1539 +/- ## ========================================== - Coverage 98.94% 98.92% -0.02% ========================================== Files 21 21 Lines 4933 4942 +9 ========================================== + Hits 4881 4889 +8 - Misses 52 53 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
🤖 I'm sorry @tleonhardt, but I was unable to process your request. Please see the logs for more details.
Member
Author
tleonhardt
commented
Dec 7, 2025
It's complaining about code coverage and the reason I think is we aren't covering the line for the case where stdout is not None in the cmd2.Cmd.__init__.
17 tasks
kmvanbrunt
kmvanbrunt
requested changes
Dec 8, 2025
kmvanbrunt
kmvanbrunt
requested changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
The
cmd2.Cmdclass no longer inherits fromcmd.Cmdand thecmd2module no longer depends on Python's built-incmdmodule.To make this happen we had to do the following:
cmd2.Cmd.__init__and several extra initializations within itcompletedefaultandcompletenamesmethodsmypywarnings