-
Notifications
You must be signed in to change notification settings - Fork 1k
fix: add warning log when using internal default simulator config #2874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FedericoMusa
wants to merge
1
commit into
pymodbus-dev:dev
from
FedericoMusa:fix/simulator-startup-warning
Open
fix: add warning log when using internal default simulator config #2874
FedericoMusa
wants to merge
1
commit into
pymodbus-dev:dev
from
FedericoMusa:fix/simulator-startup-warning
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiversen
janiversen
approved these changes
Feb 10, 2026
Collaborator
@janiversen
janiversen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
Following up on the discussion in PR #2880 regarding simulator persistence and onboarding.
While the simulator provides a great "zero-config" experience, starting it without a user-provided JSON file often leads to confusion when clients attempt to request data from non-existent registers.
This PR adds a proactive warning in the entry point logic:
setup.jsonis being used as a fallback.WARNINGindicating that a demo configuration is active.--json_file.Technical Changes
pymodbus/server/simulator/main.py: Added logic check inget_commandlineafter logging initialization to ensure the warning is formatted correctly according to the user's log level.Testing
-OS: Windows 11 Enterprise LTSC.
Shell: MINGW64 (Git Bash) / PowerShell Core.
- Running
- Running with a custom
imagepymodbus.simulatornow correctly triggers the warning logs.--json_filebypasses the warning as expected.