-
Notifications
You must be signed in to change notification settings - Fork 298
Update documentation reflecting removal of async exists #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JordanMartinez
merged 4 commits into
purescript:master
from
working-group-purescript-es:update-for-remove-fs-async-exists
Apr 14, 2022
Merged
Update documentation reflecting removal of async exists #433
JordanMartinez
merged 4 commits into
purescript:master
from
working-group-purescript-es:update-for-remove-fs-async-exists
Apr 14, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the added newline add the end of the file renders the changes wrong here in Github..
JordanMartinez
JordanMartinez
approved these changes
Apr 13, 2022
thomashoneyman
thomashoneyman
approved these changes
Apr 14, 2022
`exists` has been removed since the underlying `Async.exists` from `purescript-node-fs` has been removed.
**To fix**:
- use `exists` from the `Sync` module, if needed in an `Aff` context use `liftEffect (Sync.exists path)`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node-fs-aff doesn't have a Sync module. So, perhaps this could be clarified to say:
- import the `node-fs` package's `Node.Fs.Sync (exists)` function and wrap in `liftEffect` (e.g. `liftEffect $ Sync.exists path`)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
thomashoneyman
thomashoneyman
approved these changes
Apr 14, 2022
@JordanMartinez
JordanMartinez
deleted the
update-for-remove-fs-async-exists
branch
April 14, 2022 16:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.