-
Notifications
You must be signed in to change notification settings - Fork 0
feat(ci): RQ-64-FLOORPROSE — add the check instead of promising it (and it caught its own author) - #1185
Merged
Merged
feat(ci): RQ-64-FLOORPROSE — add the check instead of promising it (and it caught its own author) #1185avrabe merged 1 commit into
avrabe merged 1 commit into
Conversation
...g it: a LIVE pinned value may not be restated in release-artifact prose The artifact's own `verified-by` said the check "should be added rather than promised". This adds it. `check_live_floor_prose()` DERIVES the live floor from ci.yml's `--exact-emulation-floor N` and fails if any `artifacts/release-v*/` file restates that literal. ci.yml greps the emitted `floor-prose:` summary, so the rule cannot silently stop running. THE RULE IS ABOUT THE LIVE VALUE, NOT THE DIGITS — the distinction the premise correction in #1178 turns on. The floor is enforced as an EQUALITY between exactly TWO files (ci.yml and claims.yaml) which move together in the PR that moves the floor. A third copy in prose is in no lockstep and rots the moment the floor moves. But a SUPERSEDED floor quoted as dated history cannot rot, and RQ-63-FLOOREQ's transcript of a red-first run "AT v0.63" must stay legible. RED-FIRST, THREE CONSTRUCTED DIRECTIONS, each executed: 1. live floor planted in an artifact -> EXIT 1, naming the exact file:line. 2. RQ-63-FLOOREQ's three occurrences of the superseded value -> EXIT 0. The dated transcript is untouched, as the corrected premise demanded. 3. THE RULE BLINDED (gate flag renamed to `--min-emulation-floor`) -> EXIT 1, "THIS rule went blind", summary `live floor UNDERIVABLE`. It refuses to pass when it cannot see its subject, rather than reporting a clean tree. A zero-population glob fails the same way. AND A FOURTH NOBODY HAD TO CONSTRUCT: the rule fired on its own author. The first draft of the artifact's `verified-by` quoted the live floor as a literal while describing the measurement, and the checker went red naming that exact line. The obvious way to write the field WAS the defect. Recorded in the artifact rather than exempted, and the number is now cited by its derivation. Verified: status_evidence exit 0 with `floor-prose: 50 release artifacts scanned, ... restated 0 times` matching the ci.yml grep; claim_check 61/61; ci.yml parses; rivet at main's baseline. Refs #910 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YJK5LZZEkV5smCY1jKn18L
Codecov Report
✅ All modified and coverable lines are covered by tests.
📢 Thoughts on this report? Let us know!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RQ-64-FLOORPROSE (#910) — the check, not the promise
The artifact's
verified-bysaid the check "should be added rather thanpromised". This adds it.
check_live_floor_prose()derives the live floor from ci.yml's--exact-emulation-floor Nand fails if anyartifacts/release-v*/filerestates that literal. ci.yml greps the emitted
floor-prose:summary, so therule cannot silently stop running.
The rule is about the LIVE value, not the digits
The floor is enforced as an equality between exactly two files — ci.yml and
claims.yaml — which move together in the PR that moves the floor. A third copy in
prose is in no lockstep and rots the moment the floor moves. But a superseded
floor quoted as dated history cannot rot, and RQ-63-FLOOREQ's transcript of a
red-first run "AT v0.63" must stay legible. That distinction is what #1178's
premise correction turned on.
Red-first, three constructed directions
file:linelive floor UNDERIVABLEThe third is the one that matters: the rule refuses to pass when it cannot see
its subject, rather than reporting a clean tree. A zero-population glob fails
the same way.
And a fourth nobody had to construct
The rule fired on its own author. The first draft of the artifact's
verified-byquoted the live floor as a literal while describing themeasurement, and the checker went red naming that line. The obvious way to write
the field was the defect. Recorded in the artifact rather than exempted; the
number is now cited by its derivation.
Refs #910