-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[opentelemetry] fix some grammar errors#2633
Open
ryanwuer wants to merge 2 commits intoprometheus:main from
Open
[opentelemetry] fix some grammar errors #2633ryanwuer wants to merge 2 commits intoprometheus:main from
ryanwuer wants to merge 2 commits intoprometheus:main from
Conversation
Signed-off-by: Ryan Wu <rongjun0821@gmail.com>
@ryanwuer
ryanwuer
force-pushed
the
opentelemetry-grammar-errors
branch
from
April 24, 2025 02:31
4fe3d38 to
84f13e2
Compare
bwplotka
bwplotka
previously approved these changes
Oct 1, 2025
Member
@bwplotka
bwplotka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Member
bwplotka
commented
Oct 1, 2025
However we have some conflicts, do you mind resolving those?
...ar-errors # Conflicts: # docs/guides/opentelemetry.md
Author
ryanwuer
commented
Oct 10, 2025
However we have some conflicts, do you mind resolving those?
Sure, the conflicts are gone, please take another look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.