Skip to content

Navigation Menu

Sign in
Sign up

Store and use archived filename in the bin directory - #98

Open
rapphil wants to merge 1 commit into
prometheus:main from
rapphil:use-archived-filename
Open

Store and use archived filename in the bin directory #98
rapphil wants to merge 1 commit into
prometheus:main from
rapphil:use-archived-filename

Conversation

@rapphil

@rapphil rapphil commented Mar 23, 2023
edited
Loading

Copy link
Copy Markdown

In the case of the remote_write_sender tests, use the archived filename to generate the filename of the binaries stored in bin and used for the tests.

The reason why we need this is because it will provide more stable filenames since the name will not rely on the name of the published artifact.

Before this change the files stored in bin after a run of go test --tags=compliance -run "TestRemoteWrite/.+" -v were:

agent-linux-amd64
otelcol_0.42.0_linux_amd64
prometheus-2.30.3.linux-amd64
telegraf-1.20.2_linux_amd64
vector-0.16.1-x86_64-unknown-linux-gnu
vmutils-amd64-v1.67.0

After:

agent-linux-amd64 
otelcol 
prometheus 
telegraf 
vector 
vmagent-prod

This will solve #97

In the case of the remote_write_sender tests, use the archived filename
Signed-off-by: Raphael Silva <rapphil@gmail.com>

rapphil commented Mar 24, 2023

Copy link
Copy Markdown
Author

@tomwilkie can you take a look into this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /