-
Notifications
You must be signed in to change notification settings - Fork 842
Open
Conversation
Super simple hook that checks for lifespan and immediately responds type.complete, essentially making startup/shutdown lifespan events no-ops for the prometheus ASGI app. Fixes prometheus#855 ``` from hypercorn.middleware import DispatcherMiddleware from prometheus_client import make_asgi_app import asyncio async def main(): from hypercorn.asyncio import serve from hypercorn.config import Config app = DispatcherMiddleware({ "/metrics": make_asgi_app(), }) config = Config() config.bind = ["localhost:8080"] await serve(app, config) ``` Before: ``` assert scope.get("type") == "http" AssertionError ``` After: ``` [2022年11月15日 16:05:20 -0800] [59048] [INFO] Running on http://127.0.0.1:8080 (CTRL + C to quit) INFO:hypercorn.error:Running on http://127.0.0.1:8080 (CTRL + C to quit) ``` Signed-off-by: Sheena Artrip <sheena.artrip@gmail.com>
Author
sheenobu
commented
Nov 16, 2022
If an exception is raised when calling the application callable with a lifespan.startup message or a scope with type lifespan, the server must continue but not send any lifespan events.
this might be a better solution!
Member
@csmarchbanks
csmarchbanks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If an exception is raised when calling the application callable with a lifespan.startup message or a scope with type lifespan, the server must continue but not send any lifespan events.
That seems nice, could we just change the assert to instead throw an exception? That would be nice for if other types show up in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Super simple hook that checks for lifespan and immediately responds type.complete, essentially making startup/shutdown lifespan events no-ops for the prometheus ASGI app.
Fixes #855
Before:
After:
Signed-off-by: Sheena Artrip sheena.artrip@gmail.com