Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Comments

Support decoration of async functions #767

Draft
Pliner wants to merge 1 commit intoprometheus:master from
Pliner:fix-#535
Draft

Support decoration of async functions #767
Pliner wants to merge 1 commit intoprometheus:master from
Pliner:fix-#535

Conversation

@Pliner
Copy link
Contributor

@Pliner Pliner commented Feb 8, 2022

Fix #535

coneybeare, bunkerhillalex, and kakkoyun reacted with thumbs up emoji
@Pliner Pliner force-pushed the fix-#535 branch 2 times, most recently from 81f873a to 5d79d22 Compare February 8, 2022 14:46 
Signed-off-by: Yury Pliner <yury.pliner@gmail.com>
import unittest

import pytest
import aiounittest # type: ignore
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No typestub is available


f()
self.assertNotEqual(0, self.registry.get_sample_value('g'))
self.assertTrue(0.05 <= self.registry.get_sample_value('g') <= 0.1)
Copy link
Contributor Author

@Pliner Pliner Feb 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to check the expected duration. It makes more sense in a case of async functions to be sure that the decorator works fine.


f()
self.assertEqual(1, self.registry.get_sample_value('s_count'))
self.assertTrue(.05 < self.registry.get_sample_value('s_sum') < 0.1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f()
self.assertEqual(1, self.registry.get_sample_value('h_count'))
self.assertEqual(1, self.registry.get_sample_value('h_bucket', {'le': '+Inf'}))
self.assertTrue(.05 < self.registry.get_sample_value('h_sum') < 0.1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deps =
coverage
pytest
aiounittest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unittest.IsolatedAsyncioTestCase is available for python 3.8+, so this module is needed to support async version of unittest.TestCase.

Copy link
Contributor Author

Pliner commented Feb 8, 2022

Only tests to check expected behaviour were added. I hope to finalise the PR after a merge of #766.

Copy link

camlee commented Apr 24, 2022 •
edited
Loading

Can I help move this forward in any way? I've implemented the code to handle async and pushed it here:
camlee@beae31a

It passes all of your unit tests.
Konkrad and Pliner reacted with thumbs up emoji

Copy link
Member

Hey @Pliner, what's the latest state of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Async context manager

AltStyle によって変換されたページ (->オリジナル) /