-
Notifications
You must be signed in to change notification settings - Fork 842
Comments
docs: Add FastAPI + Uvicorn monitoring example#1103
docs: Add FastAPI + Uvicorn monitoring example #1103yuhao541 wants to merge 1 commit intoprometheus:master from
Conversation
- Demonstrate native ASGI integration - Include multiprocess guidance Signed-off-by: yuhao <yuhao541@qq.com>
4dc211d to
695e0d8
Compare
@csmarchbanks
csmarchbanks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on this approach, I do wonder if we should combine this with the existing Gunicorn page? Start with native, then have an additional section for gunicorn rather than two separate pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically we recommend not assigning any registry when using multiprocess. What about just leaving a comment here like # do not assign registry= when using multiprocess mode instead of assigning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not critical for an example, but livemostrecent is probably the best here to avoid counting the CPU used multiple times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than a cron-job it is usually best practice to delete the data (if it exists) when your service restarts. Otherwise some problems with counter resets can occur.
Description
This PR adds documentation for monitoring FastAPI applications running with Uvicorn ASGI server.