-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: About page uses theme background and text colors (fixes white bottom half in dark/high-contrast mode) #3563 #3571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
... styled-component imports
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.
@raclim Please review this PR. Thank You!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please Run tests locally once.
client/modules/About/About.styles.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these comments to maintain consistency with the overall code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok @yugalkaushik sir I have removed comment and running test locally. will update PR soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yugalkaushik sir, I have done everything now please review my PR and merge it if everything goes well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to address me with Sir. I'm just a contributor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@raclim can you please review my PR and merge if it's correct ?
@raclim can you please review my PR??
If there is something wrong please let me know I will do my best to fix it.
Fixes #3563
Changes:
I also solved the problem of the bottom half of the About page always having a white background, hence text difficult to read in dark and high-contrast themes.
Through the introduction of a global style that defines the background and text color for the whole page, the About page now correctly honors the chosen theme from top to bottom. This translates to improved readability and uniform appearance in all themes.
I also tidied up the imports and made sure everything employs the proper paths so that the styling is smooth.
refer to this image
Screenshot 2025年08月04日 212556 Screenshot 2025年08月04日 210218@raclim
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123