-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Added "Create folder" keyboard shortcut #3493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "Create folder" keyboard shortcut #3493
Conversation
@takshittt The Ctrl/Cmd + Alt/Option + Shift + N shortcut feels a bit tricky to use, such long key combinations don't really function as shortcuts anymore. I'd suggest switching to something shorter, like Ctrl/Cmd + Shift + N, after verifying no conflicts.
Hi @yugalkaushik,
Initially, the plan was to implement Ctrl/Cmd + Shift + N as the shortcut, but that combination conflicts with browser behavior—it’s commonly used to open a private/incognito window. I also considered Option/Alt + Shift + N, but after reviewing the codebase, it seems that introducing new modifier logic would increase complexity.
The combination Ctrl/Cmd + Alt/Option + Shift + N aligns with the existing pattern for implementing shortcuts and avoids OS-level conflicts. I’ve also discussed this in the related issue thread. That said, I agree that such long combinations may not be ideal from a usability standpoint, and it could be worth exploring a more optimal solution.
Would love to hear your thoughts on this.
Thanks for the detailed explanation! To address the usability concerns with Ctrl/Cmd + Alt/Option + Shift + N
, I suggest switching to Ctrl/Cmd + Shift + M
. It’s a simpler three-key combo, and less likely to conflict with browser shortcuts. It should also be easier for users, including those with assistive tech like screen readers.
Could you verify if this fits the codebase’s shortcut pattern and test for conflicts across platforms?
Cmd/Ctrl + Shift + M — this one’s already widely used by browsers (especially Chrome and Firefox) to toggle device emulation mode in DevTools. Since our users are likely to be developers, overriding this could interfere with a familiar and essential workflow.
Fixes #3383, #3376
Changes:
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #3383, #3376