Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[#3444] Add keyboard shortcut update functionality #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karanBRAVO wants to merge 2 commits into processing:develop
base: develop
Choose a base branch
Loading
from karanBRAVO:feat/change-keymaps

Conversation

Copy link
Contributor

@karanBRAVO karanBRAVO commented Apr 10, 2025 •
edited
Loading

This PR adds the Edit button in keyboard shortcut modal, so that users can change the keyboard shortcuts.

Fixes #3444

Changes:

  • Add the edit button
  • creates the context to share keyMaps and updateKeyMaps function

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Contributor Author

Hello @raclim,
What are your suggestions and feedback? Let me know if there's any issue.

One more thing to say, this PR is not yet completed, I have to add the same thing for all shortcuts.
Screenshot 2025年04月11日 002444

Copy link
Collaborator

raclim commented Apr 10, 2025

Thanks for the update on this!

I shared my thoughts about the development for this issue in its thread. Ideally, a pull request should be complete before submission. Since it's not complete yet, could you mark this as a draft instead?
karanBRAVO reacted with thumbs up emoji

@raclim raclim added Feature Request Proposal for adding a new functionality On Hold Work on this issue is paused for now labels Apr 10, 2025
@karanBRAVO karanBRAVO marked this pull request as draft April 10, 2025 19:06
@karanBRAVO karanBRAVO marked this pull request as ready for review April 11, 2025 20:47
Copy link
Contributor Author

Hello @raclim,
I have updated the PR, need your reviews :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature Request Proposal for adding a new functionality On Hold Work on this issue is paused for now
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the keyboard shortcuts based on user preferences

AltStyle によって変換されたページ (->オリジナル) /