-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Added support for aria labels in IconButtons & aria roles in menus #3370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dropdown menus on Mobile navbar had no roles,labels. Currently, the roles are updated as per ARIA guidelines (menu). The snapshot of MobileNav is also updated with the change in markup. Fixes the lack of description when accessibility readers are processing the button.
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.
@raclim
raclim
added
the
Area:Accessibility
Category for accessibility related features and bugs
label
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
The dropdown menus on Mobile navbar had no roles,labels. Currently, the roles are updated as per ARIA guidelines (menu). The snapshot of MobileNav is also updated with the change in markup. Fixes the lack of description when accessibility readers are processing the menu button.
(ARIA guidelines for menu- https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/menu_role)
Fixes #3369
There seems to be a fair amount of work required to improve accessibility, this fixes related issues in one file (MobileNav). Will be thinking about how to extend this to fix rrelated issues in a more streamlined manner and verify it properly.
TODO: need to add translations for the labels?
cc would appreciate feedback @espin
Changes:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123