-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Enhancement/rtl UI support #3326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.
@raclim
raclim
added
the
Area: Translation
For localization of the p5.js editor or contributor documentation
label
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #3325
Changes:
This pull request improves the support for RTL languages in the UI. It ensures proper alignment, text direction, and layout adjustments for components when using RTL scripts such as Arabic, Persian, and Hebrew.
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123Almost all tests have been reviewed and passed successfully. However, there is an issue in the test file for FileNode(FileNode.unit.test.jsx), which doesn't seem to be related to the newly added feature. The error seems more likely to be caused by issues related to accessing the store state or some unexpected test behaviors that might require further investigation.