Partitioned heat conduction (G+Smo participant) #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Crazy-Rich-Meghan wants to merge 13 commits into precice:develop

from Crazy-Rich-Meghan:partitioned-heat-conduction

Open

Partitioned heat conduction (G+Smo participant) #604

Crazy-Rich-Meghan wants to merge 13 commits into precice:develop from Crazy-Rich-Meghan:partitioned-heat-conduction

Conversation

@Crazy-Rich-Meghan

Copy link

Contributor

@Crazy-Rich-Meghan Crazy-Rich-Meghan commented Dec 4, 2024

Summary: Partitioned heat conduction G+Smo (IsoGeometric Analysis) participant
NOTE: G+Smo adapter is a submodule of the G+Smo library, to run the tutorial you need to configure G+Smo main library.

Updated README.md file, which contains instructions on how to configure G+Smo library with preCICE adapter.
Added gismo-executable folder to contain the symbolic link for the G+Smo executable.

This PR is marked as a draft because the documentation for the G+Smo adapter requires updates.

Crazy-Rich-Meghan and others added 4 commits

December 4, 2024 15:29

@Crazy-Rich-Meghan


 G+Smo cpp file; run scripts; clean scripts

0af5285

@Crazy-Rich-Meghan


 Merge branch 'precice:develop' into partitioned-heat-conduction

ec7bbcb

@Crazy-Rich-Meghan


 Update README.md for G+Smo; rename files

b66de59

@Crazy-Rich-Meghan


 Fix README.md

5a0fd18

@fsimonis fsimonis requested a review from uekerman

December 9, 2024 12:50

@uekerman

Copy link

Member

uekerman commented Dec 10, 2024

Let's first iterate on #603 and then here, OK?

@MakisH

Copy link

Member

MakisH commented Jul 17, 2025

@Crazy-Rich-Meghan do you plan to continue this development? It seems to currently be in draft state. We are happy to help get it in a good state!

@Crazy-Rich-Meghan


 Merge branch 'precice:develop' into partitioned-heat-conduction

5c46bfc

@Crazy-Rich-Meghan Crazy-Rich-Meghan marked this pull request as ready for review

September 10, 2025 22:21

@Crazy-Rich-Meghan


 Direct mesh access version for partitioned heat conduction

4b0ae69

@Crazy-Rich-Meghan

Copy link

Contributor Author

Crazy-Rich-Meghan commented Sep 10, 2025 •

edited by MakisH

Loading

Hi everyone,

Sorry for the delay! I have updated the partitioned heat conduction example from our side, this version supports the direct mesh access feature. To run the benchmark you need to do the following:
1. Clone G+Smo
2. cmake .. -DCMAKE_BUILD_TYPE=Release -DGISMO_OPTIONAL="gsPreCICE"
3. cmake --build build --target partitioned-heat-conduction -j 8
4. Install this example systemwide make install partitioned-heat-conduction
5. Go to the neumann-gismo folder run the Neumann participant with the run script.
6. Go to the dirichlet-gismo folder run the Dirichlet participant with the run script.

Let me know if you get stuck somewhere!

@MakisH

Copy link

Member

MakisH commented Oct 7, 2025

Hi @Crazy-Rich-Meghan,

thanks for the updates! I am now trying to build on my system, based on the stable branch (Commit ef4c754785cf4949d3a89b916eed807b74b97a9b, October 2).

I do get a building error, though (g++ (Ubuntu 12.3.0-1ubuntu1~22.04.2) 12.3.0):

[ 97%] Building CXX object optional/gsPreCICE/examples/CMakeFiles/partitioned-heat-conduction.dir/partitioned-heat-conduction.cpp.o
/home/gc/repos/misc/gismo/optional/gsPreCICE/examples/partitioned-heat-conduction.cpp: In function ‘int main(int, char**)’:
/home/gc/repos/misc/gismo/optional/gsPreCICE/examples/partitioned-heat-conduction.cpp:110:17: error: base operand of ‘->’ has non-pointer type ‘gismo::gsBasis<double>::domainIter’ {aka ‘gismo::gsDomainIteratorWrapper<double>’}
 110 | for (; domIt->good(); domIt->next(), k++ )
 | ^~
/home/gc/repos/misc/gismo/optional/gsPreCICE/examples/partitioned-heat-conduction.cpp:110:32: error: base operand of ‘->’ has non-pointer type ‘gismo::gsBasis<double>::domainIter’ {aka ‘gismo::gsDomainIteratorWrapper<double>’}
 110 | for (; domIt->good(); domIt->next(), k++ )
 | ^~
/home/gc/repos/misc/gismo/optional/gsPreCICE/examples/partitioned-heat-conduction.cpp:120:15: error: base operand of ‘->’ has non-pointer type ‘gismo::gsBasis<double>::domainIter’ {aka ‘gismo::gsDomainIteratorWrapper<double>’}
 120 | for (domIt->reset(); domIt->good(); domIt->next(), k++ )
 | ^~
/home/gc/repos/misc/gismo/optional/gsPreCICE/examples/partitioned-heat-conduction.cpp:120:31: error: base operand of ‘->’ has non-pointer type ‘gismo::gsBasis<double>::domainIter’ {aka ‘gismo::gsDomainIteratorWrapper<double>’}
 120 | for (domIt->reset(); domIt->good(); domIt->next(), k++ )
 | ^~
/home/gc/repos/misc/gismo/optional/gsPreCICE/examples/partitioned-heat-conduction.cpp:120:46: error: base operand of ‘->’ has non-pointer type ‘gismo::gsBasis<double>::domainIter’ {aka ‘gismo::gsDomainIteratorWrapper<double>’}
 120 | for (domIt->reset(); domIt->good(); domIt->next(), k++ )
 | ^~
/home/gc/repos/misc/gismo/optional/gsPreCICE/examples/partitioned-heat-conduction.cpp:124:29: error: base operand of ‘->’ has non-pointer type ‘gismo::gsBasis<double>::domainIter’ {aka ‘gismo::gsDomainIteratorWrapper<double>’}
 124 | QuRule->mapTo( domIt->lowerCorner(), domIt->upperCorner(),
 | ^~
/home/gc/repos/misc/gismo/optional/gsPreCICE/examples/partitioned-heat-conduction.cpp:124:51: error: base operand of ‘->’ has non-pointer type ‘gismo::gsBasis<double>::domainIter’ {aka ‘gismo::gsDomainIteratorWrapper<double>’}
 124 | QuRule->mapTo( domIt->lowerCorner(), domIt->upperCorner(),
 | ^~
gmake[3]: *** [optional/gsPreCICE/examples/CMakeFiles/partitioned-heat-conduction.dir/build.make:76: optional/gsPreCICE/examples/CMakeFiles/partitioned-heat-conduction.dir/partitioned-heat-conduction.cpp.o] Error 1
gmake[2]: *** [CMakeFiles/Makefile2:1940: optional/gsPreCICE/examples/CMakeFiles/partitioned-heat-conduction.dir/all] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:1947: optional/gsPreCICE/examples/CMakeFiles/partitioned-heat-conduction.dir/rule] Error 2
gmake: *** [Makefile:907: partitioned-heat-conduction] Error 2

By the way, I edited your instructions above to add a number next to the -j flag. Without a number, it will use as many threads as parallelizable build targets, which might fill the memory completely and make a system crash.

MakisH

MakisH reviewed

Oct 7, 2025

View reviewed changes

partitioned-heat-conduction/dirichlet-gismo/clean.sh Outdated

Comment on lines 7 to 17

# Remove precice-profiling directory

if [ -d "precice-profiling" ]; then

rm -rf precice-profiling

echo "Deleted 'precice-profiling' folder."

# Remove precice-run directory

if [ -d "../precice-run" ]; then

rm -rf ../precice-run

echo "Deleted 'precice-run' folder."

Copy link

Member

@MakisH MakisH Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be handled by clean_precice_logs(), called by clean_gismo() (see https://github.com/precice/tutorials/blob/develop/tools/cleaning-tools.sh)

partitioned-heat-conduction/dirichlet-gismo/clean.sh Outdated

Comment on lines 20 to 24

# Remove files ending with .pvd, .vts, .vtp, .log, and .txt

for ext in pvd vts vtp log txt; do

find . -type f -name "*.$ext" -exec rm -f {} \;

echo "Deleted all *.$ext files."

done

Copy link

Member

@MakisH MakisH Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit too intrusive (especially for the .txt files). Better do a fine-grained extension of clean_gismo().

Same in the neumann-gismo directory.

partitioned-heat-conduction/README.md Outdated Show resolved Hide resolved

partitioned-heat-conduction/README.md Outdated

Comment on lines 78 to 108

The G+Smo-based version of the tutorial offers IsoGeometric Analysis discretization method. To run the example you need to follow the following steps:

- Download G+Smo and Create a Build Folder

```

git clone git@github.com:gismo/gismo.git

cd gismo

mkdir build

```

- Configure G+Smo

```

cmake .. -DGISMO_OPTIONAL="<other submodules>;gsPreCICE"

```

- Build the Example

```

make partitioned-heat-conduction -j <number of threads to use>

```

- Link the compiled executable to the gismo-executable folder within the tutorial directory

```

cd <Your preCICE tutorial folder>/partitioned-heat-conduction/gismo-executable

ln -sf <You G+Smo build folder>/bin/partitioned-heat-conduction ./gismo_executable`

```

- Open two terminals and run

```

cd dirichlet-gismo

./run.sh

```

cd neumann-gismo

./run.sh

```

Copy link

Member

@MakisH MakisH Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move most of this content to the adapter documentation, and refer to that?

The path ./gismo_executable/gismo_executable is assumed by the run.sh, so it should probably be documented here. But we should better call that directory solver-gismo.

partitioned-heat-conduction/README.md Outdated Show resolved Hide resolved

partitioned-heat-conduction/images/tutorial-partitioned-heat-conduction-gismo.gif Outdated

Copy link

Member

@MakisH MakisH Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet referred to from the README.md. In principle, both FEniCS and G+Smo should give the same solution. If not, we should add the picture in the README.md together with a comment.

Crazy-Rich-Meghan and others added 3 commits

October 16, 2025 08:45

@Crazy-Rich-Meghan


 Merge branch 'precice:develop' into partitioned-heat-conduction

1df1cfc

@Crazy-Rich-Meghan @MakisH


 Update partitioned-heat-conduction/README.md

2f62738

Co-authored-by: Gerasimos Chourdakis <gerasimos.chourdakis@ipvs.uni-stuttgart.de>

@Crazy-Rich-Meghan @MakisH


 Update partitioned-heat-conduction/README.md

75fa072

Co-authored-by: Gerasimos Chourdakis <gerasimos.chourdakis@ipvs.uni-stuttgart.de>

@Crazy-Rich-Meghan

Copy link

Contributor Author

Crazy-Rich-Meghan commented Oct 17, 2025

Hi @Crazy-Rich-Meghan,

thanks for the updates! I am now trying to build on my system, based on the stable branch (Commit ef4c754785cf4949d3a89b916eed807b74b97a9b, October 2).

I do get a building error, though (g++ (Ubuntu 12.3.0-1ubuntu1~22.04.2) 12.3.0):


[ 97%] Building CXX object optional/gsPreCICE/examples/CMakeFiles/partitioned-heat-conduction.dir/partitioned-heat-conduction.cpp.o
/home/gc/repos/misc/gismo/optional/gsPreCICE/examples/partitioned-heat-conduction.cpp: In function ‘int main(int, char**)’:
/home/gc/repos/misc/gismo/optional/gsPreCICE/examples/partitioned-heat-conduction.cpp:110:17: error: base operand of ‘->’ has non-pointer type ‘gismo::gsBasis<double>::domainIter’ {aka ‘gismo::gsDomainIteratorWrapper<double>’}
 110 | for (; domIt->good(); domIt->next(), k++ )
 | ^~
/home/gc/repos/misc/gismo/optional/gsPreCICE/examples/partitioned-heat-conduction.cpp:110:32: error: base operand of ‘->’ has non-pointer type ‘gismo::gsBasis<double>::domainIter’ {aka ‘gismo::gsDomainIteratorWrapper<double>’}
 110 | for (; domIt->good(); domIt->next(), k++ )
 | ^~
/home/gc/repos/misc/gismo/optional/gsPreCICE/examples/partitioned-heat-conduction.cpp:120:15: error: base operand of ‘->’ has non-pointer type ‘gismo::gsBasis<double>::domainIter’ {aka ‘gismo::gsDomainIteratorWrapper<double>’}
 120 | for (domIt->reset(); domIt->good(); domIt->next(), k++ )
 | ^~
/home/gc/repos/misc/gismo/optional/gsPreCICE/examples/partitioned-heat-conduction.cpp:120:31: error: base operand of ‘->’ has non-pointer type ‘gismo::gsBasis<double>::domainIter’ {aka ‘gismo::gsDomainIteratorWrapper<double>’}
 120 | for (domIt->reset(); domIt->good(); domIt->next(), k++ )
 | ^~
/home/gc/repos/misc/gismo/optional/gsPreCICE/examples/partitioned-heat-conduction.cpp:120:46: error: base operand of ‘->’ has non-pointer type ‘gismo::gsBasis<double>::domainIter’ {aka ‘gismo::gsDomainIteratorWrapper<double>’}
 120 | for (domIt->reset(); domIt->good(); domIt->next(), k++ )
 | ^~
/home/gc/repos/misc/gismo/optional/gsPreCICE/examples/partitioned-heat-conduction.cpp:124:29: error: base operand of ‘->’ has non-pointer type ‘gismo::gsBasis<double>::domainIter’ {aka ‘gismo::gsDomainIteratorWrapper<double>’}
 124 | QuRule->mapTo( domIt->lowerCorner(), domIt->upperCorner(),
 | ^~
/home/gc/repos/misc/gismo/optional/gsPreCICE/examples/partitioned-heat-conduction.cpp:124:51: error: base operand of ‘->’ has non-pointer type ‘gismo::gsBasis<double>::domainIter’ {aka ‘gismo::gsDomainIteratorWrapper<double>’}
 124 | QuRule->mapTo( domIt->lowerCorner(), domIt->upperCorner(),
 | ^~
gmake[3]: *** [optional/gsPreCICE/examples/CMakeFiles/partitioned-heat-conduction.dir/build.make:76: optional/gsPreCICE/examples/CMakeFiles/partitioned-heat-conduction.dir/partitioned-heat-conduction.cpp.o] Error 1
gmake[2]: *** [CMakeFiles/Makefile2:1940: optional/gsPreCICE/examples/CMakeFiles/partitioned-heat-conduction.dir/all] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:1947: optional/gsPreCICE/examples/CMakeFiles/partitioned-heat-conduction.dir/rule] Error 2
gmake: *** [Makefile:907: partitioned-heat-conduction] Error 2

Hi @makis, have you pulled the main Gismo? We couldn't replicate the issue (on both MacOS and Ubuntu).

@MakisH MakisH added the new-tutorial-case label

Dec 21, 2025

MakisH

MakisH reviewed

Jan 9, 2026

View reviewed changes

Copy link

Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Crazy-Rich-Meghan I have not forgotten about this PR, and I see there are still some easy points to close. I added a log file with my building issue.

partitioned-heat-conduction/README.md Outdated

```

- Configure G+Smo

```

cmake .. -DGISMO_OPTIONAL="<other submodules>;gsPreCICE"

Copy link

Member

@MakisH MakisH Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need other modules for this tutorial? If not, let's remove. If yes, document.

But as I wrote in another comment, this looks like something to move to the adapter documentation.

partitioned-heat-conduction/README.md Outdated Show resolved Hide resolved

@Crazy-Rich-Meghan

Copy link

Contributor Author

Crazy-Rich-Meghan commented Jan 20, 2026

Hi @MakisH,

The domIt->good() issue has been fixed in gsPreCICE (commit e557b51). Please update your gsPreCICE to the latest version:

rm -rf optional/gsPreCICE
cmake .. -DGISMO_OPTIONAL="gsPreCICE"

MakisH

MakisH reviewed

Jan 20, 2026

View reviewed changes

partitioned-heat-conduction/README.md Outdated Show resolved Hide resolved

@MakisH


 Update partitioned-heat-conduction/README.md

c3507fc

@MakisH

Copy link

Member

MakisH commented Jan 20, 2026

Thanks, @Crazy-Rich-Meghan, this worked! The perpendicular-flap-vertex-gismo does not build for me anymore, but I will have another look.

If you have no objections, I will (later) push a few changes directly to this branch, to make the tutorial more consistent with https://precice.org/tutorials-perpendicular-flap-stress.html

MakisH and others added 2 commits

January 20, 2026 13:51

@MakisH


 Merge branch 'develop' into partitioned-heat-conduction

598712e

@Crazy-Rich-Meghan


 Address review comments for G+Smo tutorial

002ed8a

@Crazy-Rich-Meghan

Copy link

Contributor Author

Crazy-Rich-Meghan commented Jan 21, 2026

Hi @MakisH,

Thanks for the review! I've addressed your comments:

Updated clean.sh scripts to use the standard clean_gismo() function
Simplified the README.md, linking to the adapter documentation
Updated executable paths in run.sh scripts
Removed the redundant gismo.gif (same result as FEniCS)

Please let me know if there's anything else that needs to be changed.

@MakisH


 Merge branch 'develop' into partitioned-heat-conduction

a090112

Labels

new-tutorial-case

3 participants

@Crazy-Rich-Meghan @uekerman @MakisH

Uh oh!

Partitioned heat conduction (G+Smo participant) #604

Are you sure you want to change the base?

Partitioned heat conduction (G+Smo participant) #604

Uh oh!

Conversation

@Crazy-Rich-Meghan Crazy-Rich-Meghan commented Dec 4, 2024

Uh oh!

uekerman commented Dec 10, 2024

Uh oh!

MakisH commented Jul 17, 2025

Uh oh!

Crazy-Rich-Meghan commented Sep 10, 2025 • edited by MakisH Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MakisH commented Oct 7, 2025

Uh oh!

@MakisH MakisH Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

@MakisH MakisH Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@MakisH MakisH Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@MakisH MakisH Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Crazy-Rich-Meghan commented Oct 17, 2025

Uh oh!

@MakisH MakisH left a comment

Choose a reason for hiding this comment

Uh oh!

@MakisH MakisH Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Crazy-Rich-Meghan commented Jan 20, 2026

Uh oh!

Uh oh!

MakisH commented Jan 20, 2026

Uh oh!

Crazy-Rich-Meghan commented Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Crazy-Rich-Meghan commented Sep 10, 2025 •

edited by MakisH

Loading