-
-
Notifications
You must be signed in to change notification settings - Fork 264
Income Tax Calculator #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow proper project template @baljeet-singh97
Add requirements.txt, Images and be elaborative in readme with purpose. compilation steps, workflow and images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comments to your code wherever necessary
Add all the images to a folder named 'Images'
Rename your folder to Income Tax Calculator
Follow the proper README template, You can watch some other for reference and don't add githubusercontent link for images , add proper image path i.e. 'Images/imageName.png'
@baljeet-singh97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow the project structure given. @baljeet-singh97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project fiel should be as "income_tax_calculator.py"
For README.md, there is a template provided to follow. Kindly look through it. This is not how it should look like
The images should be in "Images" folder
Delete .gitignore and empty file of img.txt.
Kindly do these changes. @baljeet-singh97
updated the readme and made changes as mentioned above and followed readme template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename your "images" folder to Images
Replace the image src in README with 'Images/imageName.png'
@baljeet-singh97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only change it needs, add image in "Images" folder. That's it. @baljeet-singh97
Review my changes @Debashish-hub
@prathimacode-hub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, welcome to the repo officially. Conngrats on your first PR. Yayy. Amazing work. Keep it up. Great start. 🎉✨👏@baljeet-singh97
Congrats on merging your first Pull Request! 🎉 All the best for your amazing open source journey ahead. 🚀⚡️
Uh oh!
There was an error while loading. Please reload this page.
Related Issue
Name - Baljeet Singh
Issue no - 750
Info about the related issue
LGM-SOC'21 Participant
Contributor
Closes: #750
Describe the changes you've made
added a python script to calculate income tax calculator used tkinter for GUI.
Type of change
How Has This Been Tested?
tested on my local system using jupyter.
Checklist: