Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

I love you in python #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prathimacode-hub merged 12 commits into prathimacode-hub:main from manognyaa:main
Jul 7, 2021
Merged

Conversation

Copy link
Contributor

@manognyaa manognyaa commented Jul 6, 2021

Related Issue

  • Info about the related issue

  • LGM-SOC'21 Participant

  • DevIncept Participant

  • Contributor

Closes: #648

Describe the changes you've made

I made project wherein the cursor itself will write I love you and after writing the 3 words, it will draw a love symbol.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Once, you download the code, it will run successfully.

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated

gif link : https://github.com/manognyaa/Awesome_Python_Scripts/blob/main/GUIScripts/love/Images/screen-capture%20(11)%20(1).gif
screen-capture (11) (1)

initial stage link : https://github.com/manognyaa/Awesome_Python_Scripts/blob/main/GUIScripts/love/Images/initial.png
initial

last stage link : https://github.com/manognyaa/Awesome_Python_Scripts/blob/main/GUIScripts/love/Images/end.png
end
| Updated Screenshot |

Copy link
Contributor Author

Hello mam, I made a pr.
Please review and guide me if any changes required @prathimacode-hub mam.

@prathimacode-hub prathimacode-hub added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jul 7, 2021
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project folder should be as "Message - I Love You". Other than this, all perfect. Kidnly do these changes. @manognyaa

Copy link
Contributor Author

okay mam. thank you @prathimacode-hub mam. one minute

Copy link
Contributor Author

yes mam, i have named the folder as "Message- I Love You ". is it okay @prathimacode-hub mam ?

Copy link
Collaborator

@Debashish-hub Debashish-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the githubusercontent links of images with image path in the readme i.e. 'Images/imageName.png'
@manognyaa

Copy link
Contributor Author

yes sir, I have replaced the image path in the readme file. Please guide me if any changes are required @Debashish-hub sir.

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is approved. Great going. Keep rocking like this. 🤩👌@manognyaa

@prathimacode-hub prathimacode-hub added To Do Update Pending 🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21 & DCP21.Points will be 10 labels Jul 7, 2021
@prathimacode-hub prathimacode-hub merged commit dbf5c26 into prathimacode-hub:main Jul 7, 2021
@prathimacode-hub prathimacode-hub removed the To Do Update Pending label Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Debashish-hub Debashish-hub Debashish-hub requested changes

@prathimacode-hub prathimacode-hub prathimacode-hub approved these changes

Labels
🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21 & DCP21.Points will be 10 LGMSOC21 This issue will be considered for LGM-SOC 21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Saying I love you in python

AltStyle によって変換されたページ (->オリジナル) /