-
-
Notifications
You must be signed in to change notification settings - Fork 264
Enhanced Alarm Clock in BasicPythonScripts #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Alarm Clock in BasicPythonScripts #630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes needed:
Hey, whenever you work on enhancement you shouldn't remove things earlier participant had contributed.
I also mentioned you should add a separate "README_enhanced.md" showing the work you had done using README template. Don't do changes for existing README
Overall only program file would be modified according to project needs.
In "requirements.txt" file, you just add up the libraries you imported. Don't remove the existing ones on the file.
Also in Images", you removed earlier image and added yours. You just add up your things and update the link in your 'README_enhanced.md' file. Don't remove things which are already present.
And .mp3 file should be in "Related" folder
Kindly do these changes. @MuditCh57
@prathimacode-hub I need some help. I've deleted this branch locally because I messed all the things and created the new branch with new changes. Could you please delete this branch or if any other solution present please let me know. Thanks.
I'm really sorry 🙏 for the inconvenience
@prathimacode-hub I need some help. I've deleted this branch locally because I messed all the things and created the new branch with new changes. Could you please delete this branch or if any other solution present please let me know. Thanks.
I'm really sorry 🙏 for the inconvenience
No worries. You just delete up your forked repository from your profile. And refork it again. So that, you get with the project how it was earlier before you merged up the changes. Then do the necessary changes accordingly with respect to your files and things mentioned above. That's it you are good to push the project once again. @MuditCh57
Related Issue
Info about the related issue
LGM-SOC'21 Participant
DevIncept Participant
Contributor
Closes: #313
Describe the changes you've made
Type of change
What sort of change have you made:
How Has This Been Tested?
I gave different times to test the script.
Checklist:
Screenshots
|