Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Enhanced Alarm Clock in BasicPythonScripts #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
muditchoudhary wants to merge 3 commits into prathimacode-hub:main from muditchoudhary:MuditCh57-issue313
Closed

Enhanced Alarm Clock in BasicPythonScripts #630

muditchoudhary wants to merge 3 commits into prathimacode-hub:main from muditchoudhary:MuditCh57-issue313

Conversation

Copy link
Contributor

@muditchoudhary muditchoudhary commented Jul 3, 2021

Related Issue

  • Info about the related issue

  • LGM-SOC'21 Participant

  • DevIncept Participant

  • Contributor

Closes: #313

Describe the changes you've made

  1. I've fixed the bug of am and pm there is no need to take am and pm because the alarm clock have 24 hour system not 12 hour system.
  2. I've also added the new feature which is user can type 'stop' to off the alarm music.
  3. I've also improved the coding style mainly variables.
  4. Update the README.md with the given template.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I gave different times to test the script.

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
Original-screenshot
Updated-screenshot

|

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes needed:

Hey, whenever you work on enhancement you shouldn't remove things earlier participant had contributed.
I also mentioned you should add a separate "README_enhanced.md" showing the work you had done using README template. Don't do changes for existing README
Overall only program file would be modified according to project needs.
In "requirements.txt" file, you just add up the libraries you imported. Don't remove the existing ones on the file.
Also in Images", you removed earlier image and added yours. You just add up your things and update the link in your 'README_enhanced.md' file. Don't remove things which are already present.
And .mp3 file should be in "Related" folder

Kindly do these changes. @MuditCh57

Copy link
Contributor Author

muditchoudhary commented Jul 4, 2021
edited
Loading

@prathimacode-hub I need some help. I've deleted this branch locally because I messed all the things and created the new branch with new changes. Could you please delete this branch or if any other solution present please let me know. Thanks.
I'm really sorry 🙏 for the inconvenience

muditchoudhary reacted with eyes emoji

Copy link
Owner

prathimacode-hub commented Jul 4, 2021
edited
Loading

@prathimacode-hub I need some help. I've deleted this branch locally because I messed all the things and created the new branch with new changes. Could you please delete this branch or if any other solution present please let me know. Thanks.
I'm really sorry 🙏 for the inconvenience

No worries. You just delete up your forked repository from your profile. And refork it again. So that, you get with the project how it was earlier before you merged up the changes. Then do the necessary changes accordingly with respect to your files and things mentioned above. That's it you are good to push the project once again. @MuditCh57

@prathimacode-hub prathimacode-hub added invalid This doesn't seem right and removed LGMSOC21 This issue will be considered for LGM-SOC 21 labels Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prathimacode-hub prathimacode-hub prathimacode-hub requested changes

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in Alarm Clock, Basic Python Scripts

AltStyle によって変換されたページ (->オリジナル) /