Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

HTML to markdown #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prathimacode-hub merged 4 commits into prathimacode-hub:main from tanvi355:issue#548
Jun 30, 2021
Merged

Conversation

Copy link
Contributor

@tanvi355 tanvi355 commented Jun 30, 2021

Related Issue

Fixes #548

  • LGM-SOC'21 Participant
  • Contributor

Closes: #[issue number that will be closed through this PR]

Describe the changes you've made

Added a script to convert HTML file into markdown format.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Made a sample HTML file and tested the script on it. Screenshots are referenced in the REDAME.

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

welcome bot commented Jun 30, 2021

Hello there! 👋 Welcome to the project! 💖
Thank you and congrats 🎉 for opening your first pull request. Please adhere to our Code of Conduct. 🙌🏻 We will get back to you as soon as we can. 😄

Feel free to get in touch with me through social media handles. Hope to see you there!😄

Copy link
Collaborator

@Debashish-hub Debashish-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the images in an 'Images' folder and do changes in readme accordingly @tanvi355

@Debashish-hub Debashish-hub added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jun 30, 2021
Copy link
Contributor Author

Keep the images in an 'Images' folder and do changes in readme accordingly @tanvi355

Can you please tell me how to reference the image from the folder?

Copy link
Collaborator

Keep the images in an 'Images' folder and do changes in readme accordingly @tanvi355

Can you please tell me how to reference the image from the folder?

You can use 'Images/imageName.png' in place of the link or else you can have a look at other PRs
prathimacode-hub reacted with thumbs up emoji

Copy link
Contributor Author

Keep the images in an 'Images' folder and do changes in readme accordingly @tanvi355

Can you please tell me how to reference the image from the folder?

You can use 'Images/imageName.png' in place of the link or else you can have a look at other PRs

Got it! Thanks!

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is approved. Well done. Keep it up. Congrats. Welcome to the repo officially. ✨🎉@tanvi355

tanvi355 reacted with thumbs up emoji
@prathimacode-hub prathimacode-hub added the 🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21 & DCP21.Points will be 10 label Jun 30, 2021
@prathimacode-hub prathimacode-hub merged commit ac96f3c into prathimacode-hub:main Jun 30, 2021
Copy link

welcome bot commented Jun 30, 2021

Congrats on merging your first Pull Request! 🎉 All the best for your amazing open source journey ahead. 🚀⚡️

@prathimacode-hub prathimacode-hub removed the To Do Update Pending label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Debashish-hub Debashish-hub Debashish-hub requested changes

@prathimacode-hub prathimacode-hub prathimacode-hub approved these changes

Labels
🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21 & DCP21.Points will be 10 LGMSOC21 This issue will be considered for LGM-SOC 21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTML to markdown

AltStyle によって変換されたページ (->オリジナル) /