Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add Scrabble #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prathimacode-hub merged 15 commits into prathimacode-hub:main from NancyNegi23:main
Jun 30, 2021
Merged

Add Scrabble #571

prathimacode-hub merged 15 commits into prathimacode-hub:main from NancyNegi23:main
Jun 30, 2021

Conversation

Copy link
Contributor

@NancyNegi23 NancyNegi23 commented Jun 30, 2021
edited
Loading

Related Issue

  • Add a new script under BasicPythonScripts

  • LGM-SOC'21 Participant

  • Contributor

Closes: #568

Description

This is a basic Python project made using if-else structure and some other in-built functions of Python. It is a simpler version of Scrabble game.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I have tested the code by checking it through multiple cases.

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Output
Outputimage

Copy link

welcome bot commented Jun 30, 2021

Hello there! 👋 Welcome to the project! 💖
Thank you and congrats 🎉 for opening your first pull request. Please adhere to our Code of Conduct. 🙌🏻 We will get back to you as soon as we can. 😄

Feel free to get in touch with me through social media handles. Hope to see you there!😄

@NancyNegi23 NancyNegi23 changed the title (削除) Add Scrabble (削除ここまで) (追記) Add Scrabble #568 (追記ここまで) Jun 30, 2021
@NancyNegi23 NancyNegi23 changed the title (削除) Add Scrabble #568 (削除ここまで) (追記) Add Scrabble (追記ここまで) Jun 30, 2021
Copy link
Collaborator

@Debashish-hub Debashish-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the githubusercontent link with the path of image i.e. 'Images/imageName.png' in the readme
Rename images to Images folder.
DO follow the PR template while raising a PR
@NancyNegi23

@Debashish-hub Debashish-hub added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jun 30, 2021
Copy link
Contributor Author

I'll change the PR format. But the link of the image will work once you merge this request.

Copy link
Collaborator

I'll change the PR format. But the link of the image will work once you merge this request.

You need to change the link with file path of image

Copy link
Contributor Author

okay

Copy link
Contributor Author

@Debashish-hub I've made the changes

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the repo officially. Congrats, your PR is approved. Good start and selection of project. Well done. Yayy. ✨👏🎉@NancyNegi23

@prathimacode-hub prathimacode-hub added To Do Update Pending 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. labels Jun 30, 2021
@prathimacode-hub prathimacode-hub merged commit 6f12a3c into prathimacode-hub:main Jun 30, 2021
Copy link

welcome bot commented Jun 30, 2021

Congrats on merging your first Pull Request! 🎉 All the best for your amazing open source journey ahead. 🚀⚡️

@prathimacode-hub prathimacode-hub removed the To Do Update Pending label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Debashish-hub Debashish-hub Debashish-hub requested changes

@prathimacode-hub prathimacode-hub prathimacode-hub approved these changes

Labels
🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. LGMSOC21 This issue will be considered for LGM-SOC 21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrabble using Python

AltStyle によって変換されたページ (->オリジナル) /