Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Pattern #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prathimacode-hub merged 4 commits into prathimacode-hub:main from Ashu-1309:pattern
Jun 28, 2021
Merged

Pattern #536

prathimacode-hub merged 4 commits into prathimacode-hub:main from Ashu-1309:pattern
Jun 28, 2021

Conversation

Copy link
Contributor

@Ashu-1309 Ashu-1309 commented Jun 27, 2021
edited
Loading

Related Issue

  • Info about the related issue

  • LGM-SOC'21 Participant

  • Contributor

Closes: #521

Describe the changes you've made

Through this code we can print out different pattern

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe how have you verified the changes made

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link
Contributor Author

I will upload the Readme file tomorrow .

@Debashish-hub Debashish-hub added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jun 28, 2021
Copy link
Collaborator

@Debashish-hub Debashish-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the correct folder structure. Add readme.md, requirements.txt files @Ashu-1309

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing a "README.md" and "requirements.txt" file. Kindly add it. @Ashu-1309

@Ashu-1309 Ashu-1309 changed the title (削除) Uploading the program (削除ここまで) (追記) Pattern (追記ここまで) Jun 28, 2021
Copy link
Contributor Author

I have done all the required changes .

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unique script choosen. Good work. Keeping rising your progress. PR approved. 👌🎊🧨@Ashu-1309

@prathimacode-hub prathimacode-hub added To Do Update Pending 🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21 & DCP21.Points will be 10 labels Jun 28, 2021
@prathimacode-hub prathimacode-hub merged commit 6a54830 into prathimacode-hub:main Jun 28, 2021
Copy link
Contributor Author

You have mark to do ??? What is the purpose of to do label.

Copy link
Owner

You have mark to do ??? What is the purpose of to do label.

This mark is for us to keep track of ur scores. It's our work. Nowhere related to your PR. @Ashu-1309

@prathimacode-hub prathimacode-hub removed the To Do Update Pending label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Debashish-hub Debashish-hub Debashish-hub requested changes

@prathimacode-hub prathimacode-hub prathimacode-hub approved these changes

Labels
🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21 & DCP21.Points will be 10 LGMSOC21 This issue will be considered for LGM-SOC 21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pattern

AltStyle によって変換されたページ (->オリジナル) /