-
-
Notifications
You must be signed in to change notification settings - Fork 264
Word Transfer #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Word Transfer #427
Conversation
Hello there! 👋 Welcome to the project! 💖
Thank you and congrats 🎉 for opening your first pull request. Please adhere to our Code of Conduct. 🙌🏻 We will get back to you as soon as we can. 😄
Feel free to get in touch with me through social media handles. Hope to see you there!😄
.../File Transfer/file_transfer_client.py
Follow the PR template @kumarjeetray
Follow the PR template @kumarjeetray
Can you please tell me what I am missing, I am a bit confused
Follow the PR template @kumarjeetray
Can you please tell me what I am missing, I am a bit confused
Follow the CONTRIBUTING_GUIDELINES @kumarjeetray
@kumarjeetray First and foremost you hadn't followed the format other than what @Debashish-hub has mentioned. You worked on your PR without raising an issue nor you got it assigned to yourself. Always read the README and CONTRIBUTING GUIDELINES of the project. @kumarjeetray
Follow the PR template @kumarjeetray
Can you please tell me what I am missing, I am a bit confused
Follow the CONTRIBUTING_GUIDELINES @kumarjeetray
Yeah I saw them now. So can you please tell me what to do now. Please
Related Issue
-
Info about the related issue
-
LGM-SOC'21 Participant
-
Contributor
Closes: #427
Describe the changes you've made
Give a clear description what modifications you have made
I have made the file
What sort of change have you made:
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Code style update (formatting, local variables)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update
How Has This Been Tested?
I have run and tested the code
Checklist:
- My code follows the guidelines of this project.
- I have performed a self-review of my own code.
- I have commented my code, particularly whereever it was hard to understand.
- I have made corresponding changes to the documentation.
- My changes generate no new warnings.
- I have added tests that prove my fix is effective or that my feature works.
- Any dependent changes have been merged and published in downstream modules.
Follow the PR template @kumarjeetray
Can you please tell me what I am missing, I am a bit confused
Follow the CONTRIBUTING_GUIDELINES @kumarjeetray
Yeah I saw them now. So can you please tell me what to do now. Please
You hadn't raised the issue, neither issue was assigned to you. You created your PR directly which is completely out of context. First raise an issue using the issue template given and get an issue assigned to you first. This PR doesn't stand valid, unless you do that. You now added PR template but it should show up in the first commit message above. You can edit it and add. And one more thing, your PR template doesn't have an issue number, because you didn't get your issue assigned. Follow the process. Hope you understood what I meant. Any queries, don't hesitate to ask. @kumarjeetray
Thanks a lot for clearing the doubts. Can you please merge this or should I start afresh :"3
I am really sorry for not abiding by the rules cause I had no clue on how to proceed.
Thanks a lot for clearing the doubts. Can you please merge this or should I start afresh :"3
This won't be closed, neither you are supposed to from your end. First create an issue and get it assigned. @kumarjeetray
Thanks a lot for clearing the doubts. Can you please merge this or should I start afresh :"3
This won't be closed, neither you are supposed to from your end. First create an issue and get it assigned. @kumarjeetray
I have already done it. Please do assign. Thanks
Thanks a lot for clearing the doubts. Can you please merge this or should I start afresh :"3
This won't be closed, neither you are supposed to from your end. First create an issue and get it assigned. @kumarjeetray
I have already done it. Please do assign. Thanks
Check on with issue, it needs improvements. @kumarjeetray
Thanks a lot for clearing the doubts. Can you please merge this or should I start afresh :"3
This won't be closed, neither you are supposed to from your end. First create an issue and get it assigned. @kumarjeetray
I have already done it. Please do assign. Thanks
Check on with issue, it needs improvements. @kumarjeetray
I did the changes. Please let me know if it is okay
Now raise a separate PR with your project title, proper commit message using the PR template along with your issue number. And include all your project details. @kumarjeetray
...s/Word Transfer/word_tansfer_server.py
Related Issue
-
Info about the related issue
-
LGM-SOC'21 Participant
-
Contributor
Closes: #434
Describe the changes you've made
Give a clear description what modifications you have made
I have made the file
What sort of change have you made:
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Code style update (formatting, local variables)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update
How Has This Been Tested?
I have run and tested the code
Checklist:
- My code follows the guidelines of this project.
- I have performed a self-review of my own code.
- I have commented my code, particularly whereever it was hard to understand.
- I have made corresponding changes to the documentation.
- My changes generate no new warnings.
- I have added tests that prove my fix is effective or that my feature works.
- Any dependent changes have been merged and published in downstream modules.
You have raise a new PR with your project title. @kumarjeetray
You have raise a new PR with your project title. @kumarjeetray
I guess so because this is the only option showing up
You will be merging this right ?
You have raise a new PR with your project title. @kumarjeetray
I guess so because this is the only option showing up
You will be merging this right ?
You have raise a new PR with your project title. @kumarjeetray
I guess so because this is the only option showing up
You will be merging this right ?
No, you have to raise a new PR with the template changes you made now and add all the related files. This PR title doesn't justify your project. This time add a proper project title to your PR commit. I thought u would do that. @kumarjeetray
You have raise a new PR with your project title. @kumarjeetray
I guess so because this is the only option showing up
You will be merging this right ?
No, you have to raise a new PR with the template changes you made now and add all the related files. This PR title doesn't justify your project. This time add a proper project title to your PR commit. I thought u would do that. @kumarjeetray
Done something else this time. Do check
For transfer of information between one computer to another or from virtual machine to computer through sockets