Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add New Script : Emoji to Text #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prathimacode-hub merged 12 commits into prathimacode-hub:main from vivekthedev:main
Oct 7, 2022

Conversation

Copy link
Contributor

@vivekthedev vivekthedev commented Oct 5, 2022

Related Issue

  • Info about the related issue

  • Hacktoberfest2021 Participant

  • Contributor

Closes: #815

Describe the changes you've made

Made a script that returns the name of any emoji in text

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done :

Elaborate your README file, follow the README template.
Add requirements.txt file with libraries used in the project code.
Add comments to the code for better understanding.

@vivekthedev

@prathimacode-hub prathimacode-hub added the Request Changes Requesting for changes in PR label Oct 6, 2022
Copy link
Contributor Author

Thank You for the review
I have added necessary changes

  • Elaborated README.md file, there was not much in the script to be explained.
  • No third party packages or libraries were used to make this script that is why there is no requirements.txt file
  • I have added necessary comments to the code.

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved. 👍@vivekthedev

@prathimacode-hub prathimacode-hub added HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest Approved This PR is approved and removed Request Changes Requesting for changes in PR labels Oct 7, 2022
@prathimacode-hub prathimacode-hub merged commit 7cf74b2 into prathimacode-hub:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prathimacode-hub prathimacode-hub prathimacode-hub approved these changes

Labels
Approved This PR is approved HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Converting emoji into text in python

AltStyle によって変換されたページ (->オリジナル) /