-
-
Notifications
You must be signed in to change notification settings - Fork 264
Added a new python script #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello there! 👋 Welcome to the project! 💖
Thank you and congrats 🎉 for opening your first pull request. Please adhere to our Code of Conduct. 🙌🏻 We will get back to you as soon as we can. 😄
Feel free to get in touch with me through social media handles. Hope to see you there!😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly create an issue with issue template provided, get it assigned and in this pull request use pull request template where in you will include issue number that closes when PR is merged. There are minor changes in files. Changes to be done :
Keep your project repo as " IP Locator"
Keep your project file name in snake case : ip_locator.py and README file as README.md
In project file, add appropriate comments to get good understanding of the code
README should be elaborate and detailed. We have a README template to follow
Inclusion of compiled output is must. Add the images in "Images" folder in the project folder and include the image links in README file too.
Kindly work on the needful changes. @karanS08
Can you include the PR template provided and add the short intro of what you had done along with issue number and output screenshot? @karanS08
It is a simple IP locator which takes ip address from the user and makes an API call to ip-api.com and displays the information to you.