-
-
Notifications
You must be signed in to change notification settings - Fork 264
Add New GUI Script (QR Code Generator) #1080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly follow the guidelines given. First create an issue using issue template and include the issue number in your PR.
Changes to be done :
Screenshot you shared is of entering the text input but not generated output screenshot
And all images should be in "Images" folder in your project repository
The project filename should be in snake_case letters
We have a README template to follow and it needs more detailing
Add appropriate comments in you code to get good understanding of the project
Kindly do the needful changes. @vivekthedev
modified to snake case
Add : comments to describe the code
@prathimacode-hub Thanks for the review. I have made the needful change to the pull.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README needs some more detailing. You can follow this template as reference. Other than that, all perfect. 👍
@prathimacode-hub Thank you for providing the template, I have added necessary sections in the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR approved. Congrats and welcome to repo. Good initiation. Keep contributing. 👏🎉@vivekthedev
Uh oh!
There was an error while loading. Please reload this page.
Related Issue
Info about the related issue
Hacktoberfest2021 Participant
Contributor
Closes: #1081 number that will be closed through this PR
Describe the changes you've made
Added a new python GUI Script that generates and download a QR code after taking user's input.
Type of change
What sort of change have you made:
How Has This Been Tested?
The code is properly tested.
Checklist:
Screenshot