Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

SMS script contributed #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
advaita-saha wants to merge 1 commit into prathimacode-hub:main from advaita-saha:main
Closed

Conversation

Copy link

@advaita-saha advaita-saha commented Oct 5, 2021

Description

Added the script for sending SMS using the Kaleyra API

Fixes #1013

Adding the Script for SMS sending and the readme file for further guidance

  • New Script (non-breaking change which adds a new script to the repository)

Has This Been Tested?

  • I confirm that I have tested my script locally and verified that it works as intended.

Checklist:

  • I have gone through the contributing guidelines before making this Pull Request.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

welcome bot commented Oct 5, 2021

Hello there! 👋 Welcome to the project! 💖
Thank you and congrats 🎉 for opening your first pull request. Please adhere to our Code of Conduct. 🙌🏻 We will get back to you as soon as we can. 😄

Feel free to get in touch with me through social media handles. Hope to see you there!😄

Copy link
Author

I have contributed the script. Please review the PR. @prathimacode-hub

prathimacode-hub reacted with thumbs up emoji

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README can be elaborated more. There is a template, you can follow it up.
And follow the proper project structure. Needs more files. @advaita-saha

Copy link
Owner

Changes had been requested right. Why did u close it? @advaita-saha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prathimacode-hub prathimacode-hub prathimacode-hub requested changes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SMS sending script

AltStyle によって変換されたページ (->オリジナル) /