Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Expose the execute_utility function #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asavchkov wants to merge 1 commit into master from expose-execute-command

Conversation

Copy link
Contributor

@asavchkov asavchkov commented May 6, 2022

This function should be exposed in the package to be able to reuse it when there is a need to run commands in tests like e.g. this: https://github.com/postgrespro/pg_probackup/blob/22c808312f67a060cda3bb36e5a032784a5810f9/tests/helpers/ptrack_helpers.py#L98

Copy link

codecov bot commented May 6, 2022
edited
Loading

Codecov Report

Merging #65 (bf249d0) into master (87e9fd5) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@
## master #65 +/- ##
=======================================
 Coverage 96.05% 96.05% 
=======================================
 Files 18 18 
 Lines 1671 1671 
=======================================
 Hits 1605 1605 
 Misses 66 66 
Impacted Files Coverage Δ
testgres/__init__.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e9fd5...bf249d0. Read the comment docs.

Copy link
Contributor

Using execute_utility allowed through testgres.node.execute_utility("ls"). Is it enough @asavchkov ? Can I close the pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewBille AndrewBille Awaiting requested review from AndrewBille

@kulaginm kulaginm Awaiting requested review from kulaginm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /