Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[#247] PortManager__Generic uses lock-dirs for reserved ports #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dmitry-lipetsk wants to merge 24 commits into postgrespro:master
base: master
Choose a base branch
Loading
from dmitry-lipetsk:master-fix247--v001

Conversation

Copy link
Collaborator

@dmitry-lipetsk dmitry-lipetsk commented May 6, 2025 •
edited
Loading

New structures

  • OsLockObj: base (abstract) class to manage fs-based lock object.

Critical changes

  • utils.bound_ports is removed

Closes #247 

- [FIX] A creation of self._log_dir is moved to reserve_port method
- Code normalization [copy&paste mistakes]
- New asserts are added
- New comments are added
Copy link
Collaborator Author

dmitry-lipetsk commented May 7, 2025 •
edited
Loading

Patch was tested with probackup2.

 

1) PortManager__Generic uses OsOperations::create_lock_fs_obj to create a lock object
2) utils.bound_ports is removed
- TestTestgresLocal.test_ports_management is deleted
- TestOsOpsCommon.test_create_lock_fs_obj is added
Copy link
Collaborator Author

dmitry-lipetsk commented Jun 23, 2025 •
edited
Loading

У меня сомнения насчет это патча.

Штука полезная, но слишком требовательная к устойчивости тестов - если блокировочные каталоги не удалять, то их потом надо будет чистить руками. Это не критично для одноразовых тестовых машин, но все равно как-то не очень...

Пусть пока повисит.

Можно по умолчанию оставить все как есть, а эту фичу оформить как новый класс.

Copy link
Contributor

Какой новый класс, делали чтобы проблему устранить же. И если и с проблемой живется ок, то может просто не делать вовсе

@dmitry-lipetsk dmitry-lipetsk marked this pull request as draft June 27, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demonolock demonolock demonolock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using lock files for port reservation

AltStyle によって変換されたページ (->オリジナル) /