Skip to content

Respect PATH in a pg_probackup binary check #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

asavchkov merged 1 commit into master from respect-path

Nov 10, 2022

Merged

Respect PATH in a pg_probackup binary check #564

asavchkov merged 1 commit into master from respect-path

Nov 10, 2022

Conversation

Copy link

Contributor

@asavchkov asavchkov commented Nov 10, 2022

This modification allows one to set PGPROBACKUPBIN to a binary included in PATH.


 Check pg_probackup binary in PATH

d7cc00b

@asavchkov asavchkov requested review from Burus, kulaginm and funny-falcon

November 10, 2022 05:19

Burus approved these changes

View reviewed changes

Copy link

Contributor

@Burus Burus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.python.org/3/library/shutil.html#shutil.which действительно все условия закрывает. Все равно нет уверенности, что это в будущем не сломается с какой-то другой версией питона.

@asavchkov asavchkov merged commit 7b62d11 into master

@asavchkov asavchkov deleted the respect-path branch

November 10, 2022 10:46

@Burus Burus added this to the 2.5.11 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@asavchkov @Burus @postgres-dev