REL_2_5-PBCKP-236 #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

avaness merged 20 commits into REL_2_5 from REL_2_5-PBCKP-236

Oct 27, 2022

Merged

REL_2_5-PBCKP-236 #531

avaness merged 20 commits into REL_2_5 from REL_2_5-PBCKP-236

Oct 27, 2022

Conversation

avaness

Copy link

Contributor

@avaness avaness commented Sep 5, 2022 •

edited

Loading

@funny-falcon please review


 [PBCKP-236] stable test failure, dirty version

25fc034

@avaness avaness changed the base branch from master to REL_2_5

September 5, 2022 16:56

Ivan Lazarev added 10 commits

September 11, 2022 04:14


 [PBCKP-236] first-stage compatibility protocol impl with stubs

f78c63c


 [PBCKP-236] draft, first-stage compatibility protocol impl with stubs

1dfa5b9


 [PBCKP-236] draft, first-stage compatibility protocol impl with stubs

c3d3c02


 [PBCKP-236] draft, first-stage compatibility protocol impl with stubs

46b7079


 [PBCKP-236] draft, first-stage compatibility protocol impl with stubs

f5fde7e


 [PBCKP-236] draft, tests.CompatibilityTest.test_catchup_with_differen...

497751c

...t_remote_major_pg fixes


 [PBCKP-236] draft, solution without couple of unapplied shortenings

eefd887


 [PBCKP-236] draft, solution without macros cleanup

0604cce


 [PBCKP-236] working solution cleaned up

f61be78


 [PBCKP-236] [skip] removed unnecessary TODOs

b2091cd

avaness

avaness commented

Sep 16, 2022

View reviewed changes

src/utils/file.c Outdated Show resolved Hide resolved

avaness

avaness commented

Sep 16, 2022

View reviewed changes

src/utils/remote.c Outdated Show resolved Hide resolved

avaness

avaness commented

Sep 16, 2022

View reviewed changes

src/utils/remote.c Outdated Show resolved Hide resolved

@avaness avaness requested a review from funny-falcon

September 16, 2022 03:01

Ivan Lazarev added 3 commits

September 16, 2022 06:43


 [PBCKP-236] ANSI C fix


 [PBCKP-236] 1c+certified editions check

35df506


 [PBCKP-236] final update

b3351b5

funny-falcon

funny-falcon approved these changes

Sep 27, 2022

View reviewed changes

Copy link

Collaborator

@funny-falcon funny-falcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом, хорошо.

Я попрошу учесть замечания, хоть они больше стилистические, чем по существу.

src/utils/remote.c Outdated

static bool check_certified()

{

return strstr(PGPRO_VERSION_STR, "(certified)") ||

strstr(PGPRO_VERSION_STR, ("(standard certified)"));

Copy link

Collaborator

@funny-falcon funny-falcon Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А зачем тут скобочки вокруг строки?

Copy link

Contributor Author

@avaness avaness Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PGPRO_VERSION_STR выглядит как "PostgresPro 11.17.1 (certified) on x86_64-pc-linux-gnu, ...", скобочки отсюда, чтобы быть более strict.

src/utils/remote.c Outdated Show resolved Hide resolved

Ivan Lazarev added 2 commits

September 28, 2022 04:32


 [PBCKP-236] final update after review

6e67123


 [PBCKP-236] final update after review

1ce38ed

funny-falcon

funny-falcon reviewed

Sep 28, 2022

View reviewed changes

src/utils/remote.c Outdated

Assert(compatibility_params_array_size % 2 == 0);

for (int i = 0; i < compatibility_params_array_size; i+=2)

for (int i = 0; i < sizeofcompatibility_params; i+=2)

Copy link

Collaborator

@funny-falcon funny-falcon Sep 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Было правильно, зря убрал.

funny-falcon

funny-falcon reviewed

Sep 28, 2022

View reviewed changes

src/utils/remote.c Outdated

{

if (compatibility_params[i].strval != NULL)

result_size += snprintf(compatibility_buf + result_size, compatibility_buf_size - result_size,

"%s=%s/n",

Copy link

Collaborator

@funny-falcon funny-falcon Sep 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Слэш в другую сторону. И ниже тоже.

funny-falcon

funny-falcon reviewed

Sep 28, 2022

View reviewed changes

tests/compatibility.py

"CREATE TABLE ultimate_question2 AS SELECT 42 AS answer")

# do delta catchup with remote pg_probackup agent with another postgres major version

# this DELTA backup should fail without PBCKP-236 patch.

Copy link

Collaborator

@funny-falcon funny-falcon Sep 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А тест не должен падать в любом случае? По крайней мере, кажется что с патчем-то он точно должен падать.

Copy link

Contributor Author

@avaness avaness Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

должен, он вообще не должен срабатывать, так как ссылается на абсолютный путь на бинарь другой версии. мне не понятно почему CI не репортит это. на планерке спрошу гипотезы.


 [PBCKP-236] assert fix

c526597

@avaness avaness changed the title ~~(削除) Rel 2 5 pbckp 236 (削除ここまで)~~ (追記) REL_2_5-PBCKP-236 (追記ここまで)

Sep 29, 2022

@avaness avaness marked this pull request as ready for review

September 29, 2022 01:45

Ivan Lazarev added 2 commits

September 29, 2022 05:03


 [PBCKP-236] fix excessive warnings for vanilla

03d55d0


 [PBCKP-236] removed excessive brackets

d808a16

@avaness avaness force-pushed the REL_2_5-PBCKP-236 branch from 18f0b06 to 9b3dc02 Compare

October 24, 2022 15:38


 [PBCKP-236] added PGPROBACKUP_MANUAL testing and PGPROBACKUP_SSH_AGEN...

26f9992

...T_PATH flags.

@avaness avaness force-pushed the REL_2_5-PBCKP-236 branch from 9b3dc02 to 26f9992 Compare

October 25, 2022 00:13

@avaness avaness merged commit f2df286 into REL_2_5

Oct 27, 2022

@Burus Burus added this to the 2.5.9 milestone

Nov 2, 2022

Labels

None yet

3 participants

@avaness @funny-falcon @Burus

REL_2_5-PBCKP-236 #531

REL_2_5-PBCKP-236 #531

Uh oh!

Conversation

@avaness avaness commented Sep 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

@funny-falcon funny-falcon left a comment

Choose a reason for hiding this comment

Uh oh!

@funny-falcon funny-falcon Sep 27, 2022

Choose a reason for hiding this comment

Uh oh!

@avaness avaness Sep 27, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

@funny-falcon funny-falcon Sep 28, 2022

Choose a reason for hiding this comment

Uh oh!

@funny-falcon funny-falcon Sep 28, 2022

Choose a reason for hiding this comment

Uh oh!

@funny-falcon funny-falcon Sep 28, 2022

Choose a reason for hiding this comment

Uh oh!

@avaness avaness Sep 29, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@avaness avaness commented Sep 5, 2022 •

edited

Loading