Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Yet another PG 11 problem: postgresBeginForeignModify needs PlanState. #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Copy link
Contributor

@arssher arssher commented Jul 18, 2018

No description provided.

Copy link
Contributor Author

arssher commented Jul 18, 2018

(immediately revealed by shardman's tests)

Copy link

codecov-io commented Jul 18, 2018
edited
Loading

Codecov Report

Merging #171 into next will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@
## next #171 +/- ##
==========================================
+ Coverage 90.05% 90.05% +<.01% 
==========================================
 Files 40 40 
 Lines 6465 6468 +3 
==========================================
+ Hits 5822 5825 +3 
 Misses 643 643
Impacted Files Coverage Δ
src/partition_filter.c 95.35% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee8ef93...c07e3e3. Read the comment docs.

Copy link
Collaborator

I'll look into this tomorrow. We should add a pythonic test for this as well.

Copy link
Contributor Author

arssher commented Jul 19, 2018

Actually the test is already there, it's just usually not executed due to missing postgres_fdw.

Copy link
Collaborator

I pushed roughly the same piece of code to next. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /