-
Notifications
You must be signed in to change notification settings - Fork 69
Use analyzed expression trees for constraint construction. #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@arssher
arssher
force-pushed
the
master
branch
from
October 9, 2018 22:13
9082b3d to
dd71813
Compare
Codecov Report
Merging #163 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #163 +/- ## ======================================= Coverage 91.74% 91.74% ======================================= Files 43 43 Lines 6384 6384 ======================================= Hits 5857 5857 Misses 527 527
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update dd072e5...dd71813. Read the comment docs.
Suspended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I planned this as an easy change which would
currently we can't do that because hashvarlena declared as accepting
'internal' type, and analyzer can't pass bytea to it.
(cook_partitioning_expression), so a bit of code unification was expected.
Eventually it turned out to be much more cumbersome for various reasons (e.g.
analyzed trees should be adapted for childs due to dropped columns), so I am not
even sure it is worthwhile anymore.
Also, micro bug fix at partition_filter.c