Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[SHRDM-762] extract info from foreign join #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danolivo merged 2 commits into stable14 from sdm-14-SHRDM-762
Oct 14, 2022
Merged

Conversation

Copy link
Contributor

@pyhalov pyhalov commented Oct 12, 2022

No description provided.

Copy link
Contributor Author

pyhalov commented Oct 12, 2022

There is an issue here - we use postgres_fdw.h, which is not included in PostgreSQL installation, so out of tree build (USE_PGXS=1) is broken.

JOINS: 0
(7 rows)

EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, VERBOSE)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А почему только тривиальный Foreign Scan? Может быть еще проверить на пуше чего-то посложнее ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это просто фикс существующего теста. Там еще есть foreign join по равенству и неравенству. Что добавить? Соединения нескольких таблиц?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавил еще тест, что мы можем корректно оценить количество записей в foreign join.

@danolivo danolivo force-pushed the sdm-14-SHRDM-762 branch 2 times, most recently from 2bf2ecf to f4d7a38 Compare October 14, 2022 06:36
@danolivo danolivo merged commit ab68a33 into stable14 Oct 14, 2022
@danolivo danolivo deleted the sdm-14-SHRDM-762 branch October 14, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danolivo danolivo danolivo left review comments

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /