Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

14 look a like #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danolivo merged 4 commits into stable14 from 14-look-a-like
Jan 27, 2023
Merged

14 look a like #115

danolivo merged 4 commits into stable14 from 14-look-a-like
Jan 27, 2023

Conversation

Copy link
Collaborator

@Alena0704 Alena0704 commented Jan 20, 2023

No description provided.

Alena Rybakina added 2 commits January 20, 2023 17:21
Rewrite test for look-a-like functional. Current tests contain
correlation columns and queries have more nodes and description
features.
Add aqo_k as custom parameter to define few number of features
for prediction. Its default value is 3. Queries can contain
a larger number of features than 3 especially generic queries.
Also add predict_a_few_neibours parameter for switch avalable
to predict a few neibors than 3. It is done for not to change
the previous logic of the code
...ke test,
besides add two additional cases where look-a-like should not be applied.
aqo.c Outdated
NULL
);

DefineCustomIntVariable("aqo.k_neighbors_threshold",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь те же вопросы, что и в #112
Ну и внимательнее смотреть в свои комменты, прогонять через проверку словаря, грамматики, может быть.

Copy link
Collaborator Author

@Alena0704 Alena0704 Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Параметр переименовала и добавила более понятные описания в них.
Ответила на вопросы в #112

... for predicting
and add more understandable explanations of guc.
@danolivo danolivo merged commit 1b155f2 into stable14 Jan 27, 2023
@danolivo danolivo deleted the 14-look-a-like branch January 27, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danolivo danolivo danolivo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /