Details

Summary

The webpack-dev-middleware middleware does not validate the supplied URL address sufficiently before returning the local file. It is possible to access any file on the developer's machine.

Details

The middleware can either work with the physical filesystem when reading the files or it can use a virtualized in-memory memfs filesystem.
If writeToDisk configuration option is set to true, the physical filesystem is used:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/setupOutputFileSystem.js#L21

The getFilenameFromUrl method is used to parse URL and build the local file path.
The public path prefix is stripped from the URL, and the unsecaped path suffix is appended to the outputPath:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/getFilenameFromUrl.js#L82
As the URL is not unescaped and normalized automatically before calling the midlleware, it is possible to use %2e and %2f sequences to perform path traversal attack.

PoC

A blank project can be created containing the following configuration file webpack.config.js:
module.exports = { devServer: { devMiddleware: { writeToDisk: true } } };

When started, it is possible to access any local file, e.g. /etc/passwd:
$ curl localhost:8080/public/..%2f..%2f..%2f..%2f../etc/passwd

root:x:0:0:root:/root:/bin/bash
daemon:x:1:1:daemon:/usr/sbin:/usr/sbin/nologin
bin:x:2:2:bin:/bin:/usr/sbin/nologin
sys:x:3:3:sys:/dev:/usr/sbin/nologin
sync:x:4:65534:sync:/bin:/bin/sync
games:x:5:60:games:/usr/games:/usr/sbin/nologin

Impact

The developers using webpack-dev-server or webpack-dev-middleware are affected by the issue. When the project is started, an attacker might access any file on the developer's machine and exfiltrate the content (e.g. password, configuration files, private source code, ...).

If the development server is listening on a public IP address (or 0.0.0.0), an attacker on the local network can access the local files without any interaction from the victim (direct connection to the port).

If the server allows access from third-party domains (CORS, Allow-Access-Origin: * ), an attacker can send a malicious link to the victim. When visited, the client side script can connect to the local server and exfiltrate the local files.

Recommendation

The URL should be unescaped and normalized before any further processing.

Severity

• CVSS Score: 7.4 / 10 (High)
• Vector String: CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:H/I:N/A:N

References

• https://github.com/webpack/webpack-dev-middleware/security/advisories/GHSA-wr3j-pwj9-hqq6
• https://nvd.nist.gov/vuln/detail/CVE-2024-29180
• https://github.com/webpack/webpack-dev-middleware/commit/189c4ac7d2344ec132a4689e74dc837ec5be0132
• https://github.com/webpack/webpack-dev-middleware/commit/9670b3495da518fe667ff3428c5e4cb9f2f3d353
• https://github.com/webpack/webpack-dev-middleware/commit/e10008c762e4d5821ed6990348dabf0d4d93a10e
• https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/getFilenameFromUrl.js#L82
• https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/setupOutputFileSystem.js#L21
• https://github.com/webpack/webpack-dev-middleware/releases/tag/v5.3.4
• https://github.com/webpack/webpack-dev-middleware/releases/tag/v6.1.2
• https://github.com/webpack/webpack-dev-middleware/releases/tag/v7.1.0
• https://github.com/advisories/GHSA-wr3j-pwj9-hqq6

This data is provided by the GitHub Advisory Database (CC-BY 4.0).

v5.3.4

Compare Source

5.3.4 (2024年03月20日)

Bug Fixes

• security: do not allow to read files above (#​1779) (189c4ac)

v5.3.3

Compare Source

⚠ BREAKING CHANGES

• minimum supported webpack version is 5.0.0
• minimum supported Nodejs version is 14.15.0

5.3.3 (2022年05月18日)

Bug Fixes

• types for Request and Response (#​1271) (eeb8aa8)

5.3.2 (2022年05月17日)

Bug Fixes

• node types (#​1195) (d68ab36)

5.3.1 (2022年02月01日)

Bug Fixes

• types (#​1187) (0f82e1d)

v5.3.2

Compare Source

⚠ BREAKING CHANGES

• minimum supported webpack version is 5.0.0
• minimum supported Nodejs version is 14.15.0

5.3.3 (2022年05月18日)

Bug Fixes

• types for Request and Response (#​1271) (eeb8aa8)

5.3.2 (2022年05月17日)

Bug Fixes

• node types (#​1195) (d68ab36)

5.3.1 (2022年02月01日)

Bug Fixes

• types (#​1187) (0f82e1d)

v5.3.1

Compare Source

⚠ BREAKING CHANGES

• minimum supported webpack version is 5.0.0
• minimum supported Nodejs version is 14.15.0

5.3.3 (2022年05月18日)

Bug Fixes

• types for Request and Response (#​1271) (eeb8aa8)

5.3.2 (2022年05月17日)

Bug Fixes

• node types (#​1195) (d68ab36)

5.3.1 (2022年02月01日)

Bug Fixes

• types (#​1187) (0f82e1d)

v5.3.0

Compare Source

⚠ BREAKING CHANGES

• minimum supported webpack version is 5.0.0
• minimum supported Nodejs version is 14.15.0

5.3.3 (2022年05月18日)

Bug Fixes

• types for Request and Response (#​1271) (eeb8aa8)

5.3.2 (2022年05月17日)

Bug Fixes

• node types (#​1195) (d68ab36)

5.3.1 (2022年02月01日)

Bug Fixes

• types (#​1187) (0f82e1d)

v5.2.2

Compare Source

Features

• added types (a2fa77f)
• removed cjs wrapper (#​1146) (b6d53d3)

5.2.2 (2021年11月17日)

Chore

• update schema-utils package to 4.0.0 version

5.2.1 (2021年09月25日)

• internal release, no visible changes and features

v5.2.1

Compare Source

Features

• added types (a2fa77f)
• removed cjs wrapper (#​1146) (b6d53d3)

5.2.2 (2021年11月17日)

Chore

• update schema-utils package to 4.0.0 version

5.2.1 (2021年09月25日)

• internal release, no visible changes and features

v5.2.0

Compare Source

Features

• added types (a2fa77f)
• removed cjs wrapper (#​1146) (b6d53d3)

5.2.2 (2021年11月17日)

Chore

• update schema-utils package to 4.0.0 version

5.2.1 (2021年09月25日)

• internal release, no visible changes and features

v5.1.0

Compare Source

Features

• don't read full file if Range header is present (e8b21f0)
• output more information on errors (#​1024) (7df9e44)

Bug Fixes

• reduced package size by removing mem package (#​1027) (0d55268)

v5.0.0

Compare Source

⚠ BREAKING CHANGES

• minimum supported Node.js version is 12.13.0 (#​928) (4cffeff)

v4.3.0

Compare Source

Features

• add getFilenameFromUrl to API (#​911) (1edc726)

Bug Fixes

• husky config (#​904) (8a423be)
• typo depandabot -> dependabot (#​905) (7062990)

v4.2.0

Compare Source

Features

• allow the headers option to accept function (#​897) (966afb3)