-
Notifications
You must be signed in to change notification settings - Fork 143
Open
Conversation
@ifeLawal
ifeLawal
changed the title
(削除) Fix to issue #2012 (削除ここまで)
(追記) Fix for untitled projects in picker tile sizes (追記ここまで)
Dec 29, 2020
ifeLawal
commented
Dec 29, 2020
Author
@outoftime Sorry I don't see the + next to Reviewers to add you as a reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
I saw this open in the good first issue and thought it would be a good first tackle as a relatively new programmer.
My approach was to adjust the empty string fallback that gets returned from the generateTextPreview() method. I had 2 possible thoughts
I went with the regular expression approach since it looks empty, which matches what would be in a students <Title> tag in the html on Popcode. I used the same approach for the time section in the tile, but I was not sure how to reproduce the time actually being an empty string so any feedback on your thoughts on reproducing this, as well as if the regular expression approach makes sense, would be super helpful.
Closes #2102