-
Notifications
You must be signed in to change notification settings - Fork 143
Open
Conversation
Seems to work, we get some console errors now. Fixes: popcodeorg#1403
@outoftime
outoftime
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexpelan let’s fix the errors?
alexpelan
commented
Aug 21, 2018
Contributor
Author
@outoftime ok
outoftime
commented
Aug 28, 2018
Contributor
@alexpelan wait I swear I remember a thorough writeup about how it’s not really possible to fix the StrictMode errors until a new version of, I think, redux comes out? Where was that? Or was I dreaming?
Anywho, assuming I was not dreaming, I’ll just merge this once we no longer have library dependencies in the way ; )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to work, we get some console errors now.
Fixes: #1403