Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

fix: update vm-base-rs global deps#1491

Merged
dOrgJelli merged 1 commit intoorigin-dev from
fix-vm-base-rs
Feb 3, 2023
Merged

fix: update vm-base-rs global deps #1491
dOrgJelli merged 1 commit intoorigin-dev from
fix-vm-base-rs

Conversation

@dOrgJelli
Copy link
Contributor

@dOrgJelli dOrgJelli commented Jan 24, 2023
edited
Loading

We need to install clang as a global dependency within the rust base image, so that building/linking native c libraries can be done within builds. One example of this is within the substrate wrapper: https://github.com/polywrap/integrations/tree/main/protocol/substrate/rpc-wrapper

These dependencies used to exist, but were removed here: #1485

This lead to an error when building the the substrate wrapper, which this PR fixes.

I've already republished the polywrap/vm-base-rs:latest tag, but we still need to:

  • Build/publish this image for all CPU-arch flavors (amd64, arm, etc). We should setup CD to do this build/publishing automatically.
  • Create a patch release of Polywrap 0.9.5, which implements the same CPU-arch + version selection logic for the build images, which has been added to 0.10.0 in the PR above. This will ensure that changes to the latest tag do not modify behavior for 0.9 users.
  • Allow developers to customize the base image when building with the "vm" strategy. This will allow them to resolve problems similar to this themselves without requiring a republish to the official polywrap docker hub repository. I've started this work here, but it needs to be finished: feat: Build Manifest 0.3.0 #1370

@dOrgJelli dOrgJelli merged commit a33b11e into origin-dev Feb 3, 2023
@dOrgJelli dOrgJelli deleted the fix-vm-base-rs branch April 10, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Niraj-Kamdar Niraj-Kamdar Awaiting requested review from Niraj-Kamdar

@namesty namesty Awaiting requested review from namesty namesty is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /