-
Notifications
You must be signed in to change notification settings - Fork 136
Open
Conversation
@CodyJasonBennett
CodyJasonBennett
changed the title
(ει€) feat: SSGI (ει€γγγΎγ§)
(θΏ½θ¨) feat: SSGI + TRAA (θΏ½θ¨γγγΎγ§)
May 24, 2023
@CodyJasonBennett
CodyJasonBennett
changed the title
(ει€) feat: SSGI + TRAA (ει€γγγΎγ§)
(θΏ½θ¨) feat: SSGI + TRAA + MotionBlur (θΏ½θ¨γγγΎγ§)
May 24, 2023
@CodyJasonBennett
CodyJasonBennett
changed the title
(ει€) feat: SSGI + TRAA + MotionBlur (ει€γγγΎγ§)
(θΏ½θ¨) feat: HBAO + SSGI + TRAA + MotionBlur (θΏ½θ¨γγγΎγ§)
May 24, 2023
v1rtl
commented
May 27, 2023
Member
@CodyJasonBennett there's merge conflicts, also safe to merge after?
Contributor
Author
Can clear those in a moment. Need to do integration testing still, but it could be worthwhile to wait until 0beqz updates SSGI as it dramatically reduces memory usage and smearing. Need to also see if there's a diffuse-only or specular-only (SSR) GI and whether we can combine his effects at all. I get a broken render when combining all into an effectpass as per his readme.
dswhy
commented
Jun 21, 2023
Any estimation on when this could be available? I would really love to use the motion blur :D
This was referenced Aug 21, 2023
kitaedesigns
commented
Dec 29, 2023
Wow I cannot wait for this merge! π€€
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Implements #183
Implements 0beqz/realism-effects#5
Follows up #210 by adding HBAO + SSGI + TRAA + MotionBlur passes from 0beqz/realism-effects.
https://codesandbox.io/s/c143do
image