-
-
Notifications
You must be signed in to change notification settings - Fork 21
refactor: rename the router controller to 'find' for fetching with a ... #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 8f64cef The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
boazpoolman
commented
Oct 20, 2025
This actually seems to be a breaking change. I didn't realize that permissions are given to the controller, not the route. So renaming the controller will reset existing permissions. This will need a major version bump and will for that reason be postponed.
... a read-only API token
427746d to
2fd0445
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #338 +/- ## ======================================= Coverage 38.89% 38.89% ======================================= Files 2 2 Lines 653 653 Branches 163 163 ======================================= Hits 254 254 Misses 317 317 Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SalahAdDin
commented
Dec 28, 2025
@boazpoolman can you fix the conflicts here?
boazpoolman
commented
Dec 28, 2025
@boazpoolman can you fix the conflicts here?
@SalahAdDin I can, but I'm not merging this PR just yet as it is not such a critical feature and it does introduce a breaking change.
@boazpoolman can you fix the conflicts here?
@SalahAdDin I can, but I'm not merging this PR just yet as it is not such a critical feature and it does introduce a breaking change.
Quality code, technical debt may be 😅?
...read-only API token
What does it do?
It renames the router controller from 'router' to 'find'. I've added backwards compatibility for anybody using the controller on their own custom endpoint. This will be removed in the next major version.
Why is it needed?
To make the endpoint accessible when using a read-only API token.
How to test it?
Provide information about the environment and the path to verify the behaviour.
Related issue(s)/PR(s)
#309 #7