-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix 5186 type checking renegerate code #5199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gvwilson
gvwilson
added
P1
needed for current cycle
fix
fixes something broken
regression
this used to work
labels
May 22, 2025
emilykl
emilykl
approved these changes
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Confirming that this seems to fix syntax highlighting in VSCode on my machine.
@gvwilson
gvwilson
force-pushed
the
fix-5186-type-checking-renegerate-code
branch
from
May 25, 2025 12:48
848f68e to
44907a3
Compare
updated to remove sys imports and check again version 3.7
kszlim
commented
May 27, 2025
I'm curious if there will be a (relatively quick) patch version released once this makes it in?
@kszlim coming soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: restore type checking support in generated code