-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add support for local plotly.js/
builds to setup.py
#4526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
archmoj
merged 3 commits into
plotly:master
from
geopozo:feature/pikul-local-updateplotlyjsdev
Mar 22, 2024
Merged
Add support for local plotly.js/
builds to setup.py
#4526
archmoj
merged 3 commits into
plotly:master
from
geopozo:feature/pikul-local-updateplotlyjsdev
Mar 22, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
archmoj
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Hi, this PR adds a
--local=
flag tosetup.py updateplotlyjsdev
so we don't need to use circleci to use our custom plotly.js w/ plotly.py.This helps a little bit with community dev flow, I think.
Here is the docs:
plotly.py/contributing.md
Lines 237 to 250 in a8f5ad5
Thanks!
edit: could probably be made to work with github repos too with a little fetch here and there
Code PR
This is a small addition to the build system, not a change to plotly.py as such
plotly.graph_objects
, my modifications concern thecodegen
files and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).