-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
_bullet measure and range bars have issues if the data set has negative values #4497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...has negative values
@ksheehy
ksheehy
changed the title
(削除) _bullet has an issue building measure and range bars if the data set ... (削除ここまで)
(追記) _bullet measure and range bars have bugs if the data set has negative values (追記ここまで)
Jan 26, 2024
@ksheehy
ksheehy
changed the title
(削除) _bullet measure and range bars have bugs if the data set has negative values (削除ここまで)
(追記) _bullet measure and range bars have issues if the data set has negative values (追記ここまで)
Jan 26, 2024
Thank you for reporting this, @ksheehy
Hi @archmoj
Here's the code pen for this issue:
https://codepen.io/charming-data/pen/ExJwxRY
Thanks very much for the PR.
This looks good.
Please add a test in packages/python/plotly/plotly/tests/test_optional/test_figure_factory/test_figure_factory.py
to lock this bug.
archmoj
archmoj
reviewed
Mar 28, 2024
archmoj
archmoj
reviewed
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
The issue is with the method of sorting the data from highest to lowest. The data needs to be sorted so both, the largest positive and negative values are plotted first.
Here is the current implementation - you can see since the sort function puts the -5000 tick mark last and the bar on top of all less negative values.
Screenshot 2024年01月26日 130212
Here is a fix.
Screenshot 2024年01月26日 130307
I did a little search on this function and it looks like it is being depreciated. I appologize if I have butchered the PR process.