-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
remove duplicate FigureWidget code in graph_objects #3779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This seems like a reasonable change. I'm not sure why we handle FigureWidget differently than any other imports in this file. Python < 3.7 doesn't support .. imports, which is why we have this special handler, but it's not clear to me why we use the special handler for just FigureWidget and no other import.
In favour of this change to make this file easier to understand 👍 I'd be curious whether this breaks compatibility with <3.6 for some arcane reason though (although to be honest I'm open to requiring Python>=3.8 for Plotly.py in general).
Uh oh!
There was an error while loading. Please reload this page.
This PR removes the logic that is used to import FigureWidget in
__init__.pyfromgraph_objectsand imports it from..graph_objsinstead(I might be missing smth in my understanding - but atm I can't think of a reason why you would want exactly the same code in those two files)