-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Config options update #2199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config options update #2199
Conversation
doc/python/configuration-options.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not clear to me how this is different from the previous example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screen Shot 2020年02月17日 at 11 40 56 AM
This example has a button in the modebar rather than the hyperlink in the bottom right of the figure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, maybe add a sentence here and above, and/or have the two examples in the same section?
doc/python/configuration-options.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one would deserve more explanations I think: define responsiveness, and comment on figure behaviour when it's responsive. For example when I tried this config parameter does not make a figure responsive (resized when winodw is resized) in a Jupyter notebook, but in a Dash app the figure is responsive by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this example, I think it actually makes more sense to make it about how to disable the default responsive behavior that figures have.
I'm surprised figures aren't responsive in your Jupyter notebook- they are in mine 🤔
Thank you @jdamiba this is a very useful addition! I left some minor comments.
Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly>
Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly>
Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly>
Co-Authored-By: Emmanuelle Gouillart <emma@plot.ly>
binder/requirements.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh and dash as well :-)
doc/requirements.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and dash
@nicolaskruchten Can you please take another look at this? I reverted the style issues we are talked about in our meeting earlier this week.
@nicolaskruchten would you like me to take hover reviewing this PR? It would be great to merge it.
@emmanuelle yes please :)
Thank you @jdamiba ! This looks good to me 💃. For the "what about Dash" paragraph, is there a way to remove it since you already mention Dash? This can be done later anyway.
I fixed a merge conflict BTW.
Uh oh!
There was an error while loading. Please reload this page.
The purpose of this PR is twofold: