Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix: Calculate colorscale properly for histogram #7534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camdecoster merged 2 commits into master from cam/7533/fix-histogram-colorscale-calc
Aug 26, 2025

Conversation

Copy link
Contributor

@camdecoster camdecoster commented Aug 25, 2025 •
edited
Loading

Description

Calculate the colorscale properties for the histrogram trace when they are undefined.

Screenshots

Before After
image image

Testing

  • Be on master
  • Edit test/image/mocks/histogram_colorscale.json to remove the cmin and cmax values
  • Load the mock in DevTools
  • Note that the bar colors are all black
  • Switch to this branch
  • Load the mock in DevTools
  • Note that the bar colors are colorful

Notes

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good. You could also test this by removing cmin and cmax from the histogram_colorscale mock, as the values it includes are what it should choose automatically anyway so if the colors it ends up with match the existing mock it must have gotten the proper min and max.

camdecoster reacted with thumbs up emoji
@gvwilson gvwilson added feature something new P2 considered for next cycle labels Aug 26, 2025
Copy link
Contributor Author

💃 Looks good. You could also test this by removing cmin and cmax from the histogram_colorscale mock, as the values it includes are what it should choose automatically anyway so if the colors it ends up with match the existing mock it must have gotten the proper min and max.

That's actually a better test. I'll update the OP to show the change.

@camdecoster camdecoster merged commit b1e1157 into master Aug 26, 2025
4 of 6 checks passed
@camdecoster camdecoster deleted the cam/7533/fix-histogram-colorscale-calc branch August 26, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Labels
feature something new P2 considered for next cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /