-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: title text cannot be edited for multiple plots/components (regression since v3.0.0) #7513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: title text cannot be edited for multiple plots/components (regression since v3.0.0) #7513
Conversation
Thanks to the jasmine test, I realized that I changed the wrong line.
No ideas why the https://github.com/plotly/plotly.js/blob/bddbb149ba2ffe5baf310867ef6cf3c27af65d6a/test/jasmine/tests/transition_test.js fails.
plotly.js/test/jasmine/tests/transition_test.js
Lines 646 to 652 in bddbb14
I found that the increased delay time in #7343 is not long enough (I have no idea why it doesn't work in my case, as I haven't changed the transition logic I think).
After increasing the delay time from 50 to 100, it works when I run npm run test-jasmine -- transition locally.
However, this is unreliable in the GitHub workflow! The delay may need to be increased.
Regression since v3.0.0 (#7212)
After introducing
title.text, some plots and components edit function breaks. This PR the issue. Also closes #7512 .Affected plots
aaxis.title.text,baxis.title.text, andcaxis.title.textradialaxis.title.textAffected components
title.textxaxis.title.text