-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix edit colorbarTitleText #7487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add one sentence to the PR description explaining the effect this change has for the end user? (i.e. was editing fully broken before? or it wouldn't save? etc.)
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not able to replicate a bug as a result of this typo.
The typo was present since 2017 from b4e26ae.
The last condition would translate to
else if(prop.indexOf(true)) editAttr = 'colorbarTitleText';
Which is obliviously not what we wanted.
No description provided.