-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add performance tests #7443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance tests #7443
Conversation
I think we can skip benchmarking of pie charts - nobody could make sense of a 1000-item pie chart, so behavior at scale isn't a concern.
@gvwilson with previous improvements, each test case is isolated and run inside a fresh window.
The browser is no longer encountered crash on CI (as well as locally).
Here you could find example results: https://app.circleci.com/pipelines/github/plotly/plotly.js/12132/workflows/d9e39715-6d98-48c4-b34c-26d2baf9e57a/jobs/268411/artifacts
Now with this more stable setup we would be able to further increase the number of data points i.e. to test the failing scenarios.
@gvwilson Now the test results also include the failing cases in both all.csv
and failed.csv
files.
https://app.circleci.com/pipelines/github/plotly/plotly.js/12142/workflows/98ecc56e-d3f6-4f5d-aff1-723879408090/jobs/268665/artifacts
Uh oh!
There was an error while loading. Please reload this page.
To run all the tests for various traces please run: